Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run 'test-e2e-customconfigs' Makefile target as part of 'run-test-e2e' Makefile target #4260

Merged

Conversation

kaisoz
Copy link
Contributor

@kaisoz kaisoz commented Feb 14, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR removes the test-e2e-customconfigs Makefile target invocation from the run-test-e2e Makefile target. This is a follow-up of #4112 .

Which issue(s) this PR fixes:

Part of #3767

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 14, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2025
Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 355e808
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67af523f66fe560008b225ac

@kaisoz
Copy link
Contributor Author

kaisoz commented Feb 14, 2025

/assign @mimowo

PTAL! Thanks!

@kaisoz kaisoz force-pushed the remove-customconfigs-from-teste2e branch from 97193bc to 355e808 Compare February 14, 2025 14:25
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Cherry on the cake of great work! :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e10b6760cd9120d9db21b40f60478c0ed595974d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaisoz, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5c5bd89 into kubernetes-sigs:main Feb 14, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Feb 14, 2025
kannon92 pushed a commit to openshift/kubernetes-sigs-kueue that referenced this pull request Mar 13, 2025
kannon92 pushed a commit to openshift/kubernetes-sigs-kueue that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants