[WIP] Call isRaySubmitterJobWithAutoScaling in Job.IsTopLevel

[hiboyang]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is a follow-up for PR #8082, to call isRaySubmitterJobWithAutoScaling in Job.IsTopLevel.

Which issue(s) this PR fixes:

See previous PR #8082

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

NONE

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	470e88a
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/693bb6b2f8ae6100085a9fce

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hiboyang
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @hiboyang. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hiboyang]

Hi @mimowo , this is another follow-up work item from Ray Autocaling PR (#8082), to call isRaySubmitterJobWithAutoScaling in Job.IsTopLevel. Want to double check with you before I make further changes. We will need to pass k8sClient argument to IsTopLevel interface, right?

[mimowo]

/ok-to-test
Thank you 👍

[mimowo]

/assign @yaroslava-serdiuk
for the first pass

[yaroslava-serdiuk]

I'm not sure if this is needed. I think the existing approach (copying annotation) is fine as a temporary solution, and in long term we should disable RayJob integration. I created #8201 for that.

So let's wait for the discussion. If we are going with disabling RayJob integration, then isTopLevel() won't be needed at all. If not, we will proceed with this PR.