Skip to content

add unit test for preemption with TAS disabled #8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zhifei92 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add unit test for preemption with TAS disabled #8209

zhifei92 wants to merge 1 commit into from
+315 −0

Conversation

@zhifei92
Copy link
Contributor

@zhifei92 zhifei92 commented Dec 12, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #8194

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 12, 2025
@netlify
Copy link

netlify bot commented Dec 12, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 7fa06da
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/693c06b2eb0d0a0008247080
😎 Deploy Preview https://deploy-preview-8209--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhifei92
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 12, 2025
mimowo
mimowo reviewed Dec 12, 2025
View reviewed changes
pkg/scheduler/scheduler_tas_test.go
},
}

for name, tc := range cases {
Copy link
Contributor

@mimowo mimowo Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to merge this test case into TestScheduleForTASPreemption? We could introduce there featureGates field like in TestScheduleForTAS which would allow to disable TopologyAwareScheduling.

I know isolated tests are nice, but it also has the cost of duplicating long setup and asserts code.

@mimowo
Copy link
Contributor

mimowo commented Dec 15, 2025

/assign @PBundyra
ptal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mimowo mimowo mimowo left review comments

@gabesaba gabesaba Awaiting requested review from gabesaba

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

Assignees

@PBundyra PBundyra

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TAS: add unit test for preemption when TopologyAwareScheduling is disabled

4 participants

@zhifei92 @k8s-ci-robot @mimowo @PBundyra