-
Notifications
You must be signed in to change notification settings - Fork 500
use kueue workloads in place of workloads for future workload aware scheduling #8478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use kueue workloads in place of workloads for future workload aware scheduling #8478
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| whereas the `Preempted` condition gives more details about the preemption reason. | ||
|
|
||
| The preempting workload can be found by running `kubectl get workloads --selector=kueue.x-k8s.io/job-uid=<JobUID> --all-namespaces`. | ||
| The preempting workload can be found by running `kubectl get kueueworkloads --selector=kueue.x-k8s.io/job-uid=<JobUID> --all-namespaces`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m wondering if we need to add a kueueworkloads alias in that case. If I remember correctly, we added only kueueworkload, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, let's add kueueworkloads.
tenzen-y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we really need to replace workloads with alias name in documentations.
We can consider replacing that with workloads.kueue.x-k8s.io in the doc.
On second thought I agree with you actually. From what @JoelSpeed has mentioned to me, the only thing that is really actually guaranteed to work is to use the full path with getting these resources. So it may be best to use that to make sure we don't hit any ambiguity in our documentation. I'll update this to use the proper path. |
SGTM, thank you for your effort 🥇 |
e61da0e to
a295662
Compare
|
Thank you 👍 |
|
@mimowo: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
LGTM label has been added. DetailsGit tree hash: 5db450132200e6d20728909d2012273e7dd2116f |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mimowo: new pull request created: #8504 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Use
kueueworkloadsinstead ofworkloadsto not pick in-tree workload object in futureWhich issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?