Skip to content

Conversation

@kannon92
Copy link
Contributor

@kannon92 kannon92 commented Jan 8, 2026

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Use kueueworkloads instead of workloads to not pick in-tree workload object in future

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Jan 8, 2026
@netlify
Copy link

netlify bot commented Jan 8, 2026

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit a295662
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69612cde34d6c80008f42b32
😎 Deploy Preview https://deploy-preview-8478--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2026
@kannon92 kannon92 changed the title use kueue workloads in place of workloads for future workload aware s… use kueue workloads in place of workloads for future workload aware scheduling Jan 8, 2026
@kannon92
Copy link
Contributor Author

kannon92 commented Jan 8, 2026

cc @mimowo @tenzen-y

whereas the `Preempted` condition gives more details about the preemption reason.

The preempting workload can be found by running `kubectl get workloads --selector=kueue.x-k8s.io/job-uid=<JobUID> --all-namespaces`.
The preempting workload can be found by running `kubectl get kueueworkloads --selector=kueue.x-k8s.io/job-uid=<JobUID> --all-namespaces`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m wondering if we need to add a kueueworkloads alias in that case. If I remember correctly, we added only kueueworkload, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, let's add kueueworkloads.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we really need to replace workloads with alias name in documentations.

We can consider replacing that with workloads.kueue.x-k8s.io in the doc.

@kannon92
Copy link
Contributor Author

kannon92 commented Jan 9, 2026

We can consider replacing that with workloads.kueue.x-k8s.io in the doc.

On second thought I agree with you actually.

From what @JoelSpeed has mentioned to me, the only thing that is really actually guaranteed to work is to use the full path with getting these resources. So it may be best to use that to make sure we don't hit any ambiguity in our documentation.

I'll update this to use the proper path.

@tenzen-y
Copy link
Member

tenzen-y commented Jan 9, 2026

We can consider replacing that with workloads.kueue.x-k8s.io in the doc.

On second thought I agree with you actually.

From what @JoelSpeed has mentioned to me, the only thing that is really actually guaranteed to work is to use the full path with getting these resources. So it may be best to use that to make sure we don't hit any ambiguity in our documentation.

I'll update this to use the proper path.

SGTM, thank you for your effort 🥇

@kannon92 kannon92 force-pushed the drop-use-workload-site branch from e61da0e to a295662 Compare January 9, 2026 16:29
@mimowo
Copy link
Contributor

mimowo commented Jan 9, 2026

Thank you 👍
/lgtm
/approve
/cherrypick website
Since this would always work then we can already cherrypick to website

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of website in a new PR and assign it to you.

Details

In response to this:

Thank you 👍
/lgtm
/approve
/cherrypick website
Since this would always work then we can already cherrypick to website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2026
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 5db450132200e6d20728909d2012273e7dd2116f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2026
@k8s-ci-robot k8s-ci-robot merged commit 619e68f into kubernetes-sigs:main Jan 9, 2026
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.16 milestone Jan 9, 2026
@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: new pull request created: #8504

Details

In response to this:

Thank you 👍
/lgtm
/approve
/cherrypick website
Since this would always work then we can already cherrypick to website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants