Automate adding kind/* labels to cherry-pick PRs

[vladikkuzn]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Copies kind labels from original PR

Which issue(s) this PR fixes:

Part of #9222

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	a7eae88
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/699326cbfde3d300073025d8

[vladikkuzn]

/cc @mbobrovskyi

[vladikkuzn]

/cc @tenzen-y
/assign

[mbobrovskyi]

Oh, this is very good. Just one thing: I think we need to merge this into https://github.com/kubernetes/kubernetes/blob/master/hack/cherry_pick_pull.sh
first.

[mbobrovskyi]

Did you test this? I saw that you created a cherry-pick: #9285, but it was without the kind/bug label.

[mbobrovskyi]

Also, please change “fixes” to “part of” in PR descriptions to avoid accidentally closing issues. We also need to improve Prow cherry-picks.

[mimowo]

Oh, this is very good. Just one thing: I think we need to merge this into https://github.com/kubernetes/kubernetes/blob/master/hack/cherry_pick_pull.sh
first.

I'm ok to merge it into our script first, as this can be already helpful. Still, please open a PR against k/k.

[kannon92]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: e04d70682d06175929f30bb2ffc9e545ba5fb0f2

[kannon92]

/lgtm cancel

Looks like this is being reviewed already.

[mbobrovskyi]

Did you test this? I saw that you created a cherry-pick: #9285, but it was without the kind/bug label.

@vladikkuzn could you please create a test cherry-pick to verify that it’s working correctly?

[vladikkuzn]

This works on own repos, but since only k8s-ci-cobot can change labels you receive:

pull request update failed: GraphQL: vladikkuzn does not have permission to update the pull request PR_kwDOG2kQZs7EG8y5. (updatePullRequest)

Checking what could be done

[mbobrovskyi]

This works on own repos, but since only k8s-ci-cobot can change labels you receive:

pull request update failed: GraphQL: vladikkuzn does not have permission to update the pull request PR_kwDOG2kQZs7EG8y5. (updatePullRequest)

Checking what could be done

Ah, I see. Then we need to add these labels (e.g. /kind bug) in the PR description.

[vladikkuzn]

Works perfectly now :)

[tenzen-y]

Oh, this is very good. Just one thing: I think we need to merge this into https://github.com/kubernetes/kubernetes/blob/master/hack/cherry_pick_pull.sh
first.

I'm ok to merge it into our script first, as this can be already helpful. Still, please open a PR against k/k.

Oh, this is very good. Just one thing: I think we need to merge this into https://github.com/kubernetes/kubernetes/blob/master/hack/cherry_pick_pull.sh
first.

I'm ok to merge it into our script first, as this can be already helpful. Still, please open a PR against k/k.

I'm fine with that. This PR could help when we generate cherry-pick PRs manually.

[mimowo]

I'm fine with that. This PR could help when we generate cherry-pick PRs manually.

Yeah, and if we show the code works, it will be easier to make the change in k/k as already tested.

[vladikkuzn]

Oh, let me open PR to k/k

[tenzen-y]

I'm fine with that. This PR could help when we generate cherry-pick PRs manually.

Yeah, and if we show the code works, it will be easier to make the change in k/k as already tested.

If we get the feedback (e.g., supporting area label as well) in k/k, we can back port the feed back to kueue repo.

[vladikkuzn]

kubernetes/kubernetes#137051

[mbobrovskyi]

Suggested change

	<!--
	Add one of the following kinds:
	/kind bug
	/kind cleanup
	/kind documentation
	/kind feature
	Optionally add one or more of the following kinds if applicable:
	/kind api-change
	/kind deprecation
	/kind failing-test
	/kind flake
	/kind regression
	-->

Do we need this comments?

[mimowo]

Yeah, I think we can skip them to make the PR minimal

[mimowo]

/lgtm
/approve
This can already be benefiting us. We can address #9290 (comment) in a follow up

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: ae04ff6d06bb6bfdea12cbde27e1ecc69f42cc34

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, vladikkuzn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment