Remove deprecated TASProfileLeastFreeCapacity feature gate#9298
Open
kannon92 wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
Remove deprecated TASProfileLeastFreeCapacity feature gate#9298kannon92 wants to merge 1 commit intokubernetes-sigs:mainfrom
kannon92 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
kind/cleanup
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XXL
kannon92
force-pushed
the
TASProfileLeastFreeCapacity-drop
branch
from
5b44a74 to
97437a4
Compare
kannon92
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
kannon92
force-pushed
the
TASProfileLeastFreeCapacity-drop
branch
from
97437a4 to
60434a6
Compare
The TASProfileLeastFreeCapacity feature gate was deprecated in v0.11, superseded by TASProfileMixed which uses LeastFreeCapacity only for unconstrained requests and BestFit for required/preferred. This removes the gate, simplifies validation logic, and drops all associated tests.
kannon92
force-pushed
the
TASProfileLeastFreeCapacity-drop
branch
from
60434a6 to
a3dee47
Compare
kannon92
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Removes the deprecated
TASProfileLeastFreeCapacityfeature gate and all its references across the codebase.TASProfileLeastFreeCapacitywas introduced in v0.10 (Alpha) and deprecated in v0.11. It enabled LeastFreeCapacity scheduling for all TAS topology request types (required, preferred, unconstrained). It has been superseded byTASProfileMixed, which uses LeastFreeCapacity only for unconstrained requests and BestFit for required/preferred — the recommended behavior.Changes:
pkg/features/kube_features.gouseLeastFreeCapacityAlgorithm()inpkg/cache/scheduler/tas_flavor_snapshot.goto only checkTASProfileMixedValidateFeatureGates()inpkg/config/validation.go— the multi-profile conflict check is no longer neededpkg/cache/scheduler/tas_cache_test.gothat exercisedTASProfileLeastFreeCapacitybehaviorpkg/config/validation_test.goWhich issue(s) this PR fixes:
Part of #8855
Special notes for your reviewer:
Unconstrained LeastFreeCapacity behavior continues to be tested via existing
TASProfileMixedtest cases.Does this PR introduce a user-facing change?