Skip to content

[Refactor] queue.Manager Factory for unit tests#9321

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
gabesaba:unit_factory
Feb 17, 2026
Merged

[Refactor] queue.Manager Factory for unit tests#9321
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
gabesaba:unit_factory

Conversation

@gabesaba
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Follow-up to #9224, prep for #9232, part of #8095.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 17, 2026
@netlify
Copy link

netlify bot commented Feb 17, 2026

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit dd79fe0
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/699484a858abe50009af4f06

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2026
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2026
@mimowo
Copy link
Contributor

mimowo commented Feb 17, 2026

@mimowo
Copy link
Contributor

mimowo commented Feb 17, 2026

/lgtm
/approve
Let's go with that
/cherrypick release-0.16
/cherrypick release-0.15

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of release-0.15, release-0.16 in new PRs and assign them to you.

Details

In response to this:

/lgtm
/approve
Let's go with that
/cherrypick release-0.16
/cherrypick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2026
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 4909ba720db59e25bad65ab26ed5ac5db4a69f4e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabesaba, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mimowo
Copy link
Contributor

mimowo commented Feb 17, 2026

/test pull-kueue-test-e2e-multikueue-main

@k8s-ci-robot k8s-ci-robot merged commit a21c174 into kubernetes-sigs:main Feb 17, 2026
32 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.17 milestone Feb 17, 2026
@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: #9321 failed to apply on top of branch "release-0.16":

Applying: queue.Manager Factory for unit tests
Using index info to reconstruct a base tree...
M	pkg/cache/queue/manager.go
M	pkg/cache/queue/manager_test.go
M	pkg/controller/core/workload_controller_test.go
M	pkg/controller/jobframework/base_webhook_test.go
M	pkg/controller/jobs/job/job_webhook_test.go
M	pkg/scheduler/scheduler_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/scheduler/scheduler_test.go
Auto-merging pkg/controller/jobs/job/job_webhook_test.go
Auto-merging pkg/controller/jobframework/base_webhook_test.go
Auto-merging pkg/controller/core/workload_controller_test.go
CONFLICT (content): Merge conflict in pkg/controller/core/workload_controller_test.go
Auto-merging pkg/cache/queue/manager_test.go
CONFLICT (content): Merge conflict in pkg/cache/queue/manager_test.go
Auto-merging pkg/cache/queue/manager.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 queue.Manager Factory for unit tests

Details

In response to this:

/lgtm
/approve
Let's go with that
/cherrypick release-0.16
/cherrypick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: #9321 failed to apply on top of branch "release-0.15":

Applying: queue.Manager Factory for unit tests
Using index info to reconstruct a base tree...
M	pkg/cache/queue/manager.go
M	pkg/cache/queue/manager_test.go
M	pkg/controller/core/clusterqueue_controller_test.go
M	pkg/controller/core/localqueue_controller_test.go
M	pkg/controller/core/workload_controller_test.go
M	pkg/controller/jobframework/base_webhook_test.go
M	pkg/controller/jobs/job/job_webhook_test.go
M	pkg/scheduler/scheduler_tas_test.go
M	pkg/scheduler/scheduler_test.go
M	pkg/visibility/storage/pending_workloads_cq_test.go
M	pkg/visibility/storage/pending_workloads_lq_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/visibility/storage/pending_workloads_lq_test.go
CONFLICT (content): Merge conflict in pkg/visibility/storage/pending_workloads_lq_test.go
Auto-merging pkg/visibility/storage/pending_workloads_cq_test.go
CONFLICT (content): Merge conflict in pkg/visibility/storage/pending_workloads_cq_test.go
Auto-merging pkg/scheduler/scheduler_test.go
Auto-merging pkg/scheduler/scheduler_tas_test.go
Auto-merging pkg/controller/jobs/job/job_webhook_test.go
Auto-merging pkg/controller/jobframework/base_webhook_test.go
Auto-merging pkg/controller/core/workload_controller_test.go
CONFLICT (content): Merge conflict in pkg/controller/core/workload_controller_test.go
Auto-merging pkg/controller/core/localqueue_controller_test.go
Auto-merging pkg/controller/core/clusterqueue_controller_test.go
Auto-merging pkg/cache/queue/manager_test.go
CONFLICT (content): Merge conflict in pkg/cache/queue/manager_test.go
Auto-merging pkg/cache/queue/manager.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 queue.Manager Factory for unit tests

Details

In response to this:

/lgtm
/approve
Let's go with that
/cherrypick release-0.16
/cherrypick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants