api/image: escape images[].name before interpolating into regexp

[zanarellidev]

Summary

images[].name is documented as an identical/literal image name match:

// Name is a tag-less image name.

but IsImageMatched splices it unescaped into a regexp pattern:

pattern, err := regexp.Compile("^" + t + "(:...)?(@...)?$")

Since . is a regexp metacharacter and appears in virtually every real registry hostname (gcr.io, docker.io, quay.io, ghcr.io, *.azurecr.io), a rule such as:

images:
  - name: gcr.io/my-project/my-app
    newTag: v2

would also match an unrelated image like gcrXio/my-project/my-app if one happened to be present in the same manifest set, contradicting the documented "identical" semantics.

This line has had two recent fixes for adjacent issues (#6184 panic-on-invalid-regexp, #6167 digest-algorithm matching) that didn't touch this particular gap.

Fix

Wrap the interpolated name in regexp.QuoteMeta so it's matched literally, per commit 2.

Test plan

• Added a failing-first regression test at the unit level (image_test.go) and an end-to-end krusty test (transformersimage_test.go), following this repo's own documented reviewer-guide shape (failing-test commit, then fix commit).
• Verified via git checkout <test-commit> -- image.go (pre-fix) that both new tests fail on unmodified HEAD.
• Verified both tests pass after the fix, alongside all existing tests in api/internal/image/... and api/krusty/....

[kubernetes-prow]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kubernetes-prow]

Welcome @zanarellidev!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[kubernetes-prow]

Hi @zanarellidev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[saitejabandaru-in]

Excellent catch! Escaping the input with regexp.QuoteMeta is the correct approach to prevent regex injection/wildcard matching for image names. The tests clearly demonstrate the issue and verify the fix.

[saitejabandaru-in]

LGTM! Excellent catch. Using regexp.QuoteMeta is exactly the right approach here to prevent image registries containing dots from accidentally matching wildcard characters. The added tests look very comprehensive too.

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saitejabandaru-in, zanarellidev
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment