Skip to content

docs: replace deprecated commonLabels in examples - #6217

Open
locker95 wants to merge 1 commit into
kubernetes-sigs:masterfrom
locker95:docs/helloWorld-labels-not-commonLabels
Open

docs: replace deprecated commonLabels in examples#6217
locker95 wants to merge 1 commit into
kubernetes-sigs:masterfrom
locker95:docs/helloWorld-labels-not-commonLabels

Conversation

@locker95

@locker95 locker95 commented Aug 7, 2026

Copy link
Copy Markdown

commonLabels warns to use labels instead. The helloWorld base and demo overlays (and the breakfast tutorial) still used the old field, so following them always trips that deprecation.

Switched those examples to labels with includeSelectors: true, which matches the old commonLabels behavior.

Fixes #5653

commonLabels has been deprecated in favor of labels with
includeSelectors. Update the helloWorld demo and breakfast
tutorial so people following them stop hitting the warning.


Signed-off-by: Dean Chen <862469039@qq.com>
@kubernetes-prow kubernetes-prow Bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 7, 2026
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @locker95. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 7, 2026

@saitejabandaru-in saitejabandaru-in left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This perfectly migrates the deprecated commonLabels to the new labels field in the examples. Great cleanup!

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: locker95, saitejabandaru-in
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@locker95
locker95 force-pushed the docs/helloWorld-labels-not-commonLabels branch from ee35459 to 5169264 Compare August 11, 2026 06:55
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kustomize example in README uses deprecated commonLabels

2 participants