docs: replace deprecated commonLabels in examples - #6217
Conversation
commonLabels has been deprecated in favor of labels with includeSelectors. Update the helloWorld demo and breakfast tutorial so people following them stop hitting the warning. Signed-off-by: Dean Chen <862469039@qq.com>
|
Hi @locker95. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
saitejabandaru-in
left a comment
There was a problem hiding this comment.
LGTM! This perfectly migrates the deprecated commonLabels to the new labels field in the examples. Great cleanup!
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: locker95, saitejabandaru-in The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ee35459 to
5169264
Compare
commonLabelswarns to uselabelsinstead. The helloWorld base and demo overlays (and the breakfast tutorial) still used the old field, so following them always trips that deprecation.Switched those examples to
labelswithincludeSelectors: true, which matches the old commonLabels behavior.Fixes #5653