fix: support integer keys when marshaling resources to JSON - #6223
fix: support integer keys when marshaling resources to JSON#6223iahsanGill wants to merge 2 commits into
Conversation
|
This PR has multiple commits, and the default merge method is: merge. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @iahsanGill! |
|
Hi @iahsanGill. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iahsanGill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
What this PR does / why we need it:
RNode.MarshalJSONcurrently decodes YAML into Go maps before marshaling JSON. YAML mappings with integer keys becomemap[interface{}]interface{}, whichencoding/jsoncannot marshal.This uses
YAMLToJSONStrictfor the conversion instead. Integer-looking mapping keys are preserved as JSON object keys, and duplicate YAML keys remain validation errors.Fixes #3446
Testing:
go test ./yaml -count=1fromkyamlgo test ./krusty -run 'Test(IntegerKey|DuplicateKeys)$' -count=1fromapi/kind bug