Fix silent failure of kustomize version with invalid output format - #6227
Fix silent failure of kustomize version with invalid output format#6227saitejabandaru-in wants to merge 2 commits into
Conversation
…former and SuffixTransformer
This adds validation for the --output flag to return an error if it's not 'yaml' or 'json', fixing a bug where it would silently fail and output nothing.
|
This PR has multiple commits, and the default merge method is: merge. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: saitejabandaru-in The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @saitejabandaru-in. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #6032
When using
kustomize version --output=ymlor any invalid output format, the command used to silently succeed without any output. This PR adds validation to return an error if the output format is notyamlorjson, similar to howkubectl versionbehaves.