Skip to content

Fix silent failure of kustomize version with invalid output format - #6227

Open
saitejabandaru-in wants to merge 2 commits into
kubernetes-sigs:masterfrom
saitejabandaru-in:fix-version-output
Open

Fix silent failure of kustomize version with invalid output format#6227
saitejabandaru-in wants to merge 2 commits into
kubernetes-sigs:masterfrom
saitejabandaru-in:fix-version-output

Conversation

@saitejabandaru-in

Copy link
Copy Markdown

Fixes #6032

When using kustomize version --output=yml or any invalid output format, the command used to silently succeed without any output. This PR adds validation to return an error if the output format is not yaml or json, similar to how kubectl version behaves.

Sai Teja Bandaru added 2 commits August 7, 2026 22:47
This adds validation for the --output flag to return an error if it's not 'yaml' or 'json', fixing a bug where it would silently fail and output nothing.
@kubernetes-prow

Copy link
Copy Markdown
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linux-foundation-easycla

Copy link
Copy Markdown

CLA Missing ID

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saitejabandaru-in
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 15, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @saitejabandaru-in. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kustomize version command: invalid --output value fails silently

1 participant