Try to fix Helm so it does not allow deleting CRDs

[Mostafahassen1]

Issue => #695

The issue is not fixed yet. I am trying to fix it, but I may be going in the wrong direction. I need help to find the correct way to resolve this issue.

I used the following commands to run the application:

eval $(minikube docker-env)

docker build -t my-lws:dev .

CHART_VERSION=0.6.1

helm upgrade --install lws oci://registry.k8s.io/lws/charts/lws \
  --version=$CHART_VERSION \
  --namespace lws-system \
  --create-namespace \
  --set manager.image.repository=my-lws \
  --set manager.image.tag=dev \
  --set manager.image.pullPolicy=Never \
  --wait --timeout 300s

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mostafahassen1
Once this PR has been reviewed and has the lgtm label, please assign edwinhr716 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-lws canceled.

Name	Link
🔨 Latest commit	7504fbd
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-lws/deploys/693f0e56aaaa9800086e74bb

[k8s-ci-robot]

Welcome @Mostafahassen1!

It looks like this is your first PR to kubernetes-sigs/lws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/lws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Mostafahassen1. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Mostafahassen1]

Hi @Edwinhr716, please review this when you have time.

[kerthcet]

I think the problem is because crds is placed under the template folder, but in practice, we should make them in parallel.

[Mostafahassen1]

I think the problem is because crds is placed under the template folder, but in practice, we should make them in parallel.

Hi @kerthcet, I worked on the issue again by moving the crds out of the templates/ directory. I then tested the app to check whether Helm deletes the CRDs, but I found that it still deletes them.

[kerthcet]

I tested locally, can you verify again? We're talking about CRD here.