Skip to content

fix(e2e): use standardized labels in TestServiceSelectorDrift - #322

Open
alanhuangch wants to merge 1 commit into
kubernetes-sigs:mainfrom
alanhuangch:fix-standardized-labels-test-service-selector-drift
Open

fix(e2e): use standardized labels in TestServiceSelectorDrift#322
alanhuangch wants to merge 1 commit into
kubernetes-sigs:mainfrom
alanhuangch:fix-standardized-labels-test-service-selector-drift

Conversation

@alanhuangch

@alanhuangch alanhuangch commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Replace non-standard labels (type=reconciliation, scenario=drift-service-selector) with the framework-provided category/speed/scenario labels so the test can be selected by the smoke/extended profiles.

Fixes #320

Summary by CodeRabbit

  • Tests
    • Updated reconciliation end-to-end test labels to use standardized categories, speed, and scenario values.
    • Improved consistency and reliability of service selector drift test coverage.

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 14, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alanhuangch
Once this PR has been reviewed and has the lgtm label, please assign mikebrow for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploy Preview for mcp-lifecycle-operator ready!

Name Link
🔨 Latest commit 0ef0ca8
🔍 Latest deploy log https://app.netlify.com/projects/mcp-lifecycle-operator/deploys/6a7f398784aaf400080fb2ea
😎 Deploy Preview https://deploy-preview-322--mcp-lifecycle-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubernetes-prow
kubernetes-prow Bot requested review from Cali0707 and soltysh August 14, 2026 15:39
@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @alanhuangch. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2026
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 660035f0-a2e6-4c2d-a597-082459de57c4

📥 Commits

Reviewing files that changed from the base of the PR and between b9d6e92 and 4b435e8.

📒 Files selected for processing (1)
  • test/e2e/reconciliation_test.go

📝 Walkthrough

Walkthrough

TestServiceSelectorDrift now uses shared constants for its lifecycle, speed, and scenario labels.

Changes

Label standardization

Layer / File(s) Summary
Update drift test labels
test/e2e/reconciliation_test.go
TestServiceSelectorDrift replaces literal labels with shared framework constants.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4b435

This PR only standardizes labels for an end-to-end test, with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: cardil, matzew

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes satisfy issue #320 by replacing custom test labels with framework-provided standardized labels.
Out of Scope Changes check ✅ Passed The changes are limited to updating labels in TestServiceSelectorDrift and match the linked issue scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: replacing custom labels with standardized labels in TestServiceSelectorDrift.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.02%. Comparing base (e221991) to head (0ef0ca8).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #322       +/-   ##
===========================================
+ Coverage   71.77%   86.02%   +14.25%     
===========================================
  Files          22       14        -8     
  Lines        2172     1689      -483     
===========================================
- Hits         1559     1453      -106     
+ Misses        558      191      -367     
+ Partials       55       45       -10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Replace non-standard labels (type=reconciliation, scenario=drift-service-selector)
with the framework-provided category/speed/scenario labels so the test can be
selected by the smoke/extended profiles.
@alanhuangch
alanhuangch force-pushed the fix-standardized-labels-test-service-selector-drift branch from 4b435e8 to 0ef0ca8 Compare August 14, 2026 15:51
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The labels TestServiceSelectorDrift are not using standardized ones

1 participant