fix(e2e): use standardized labels in TestServiceSelectorDrift - #322
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alanhuangch The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for mcp-lifecycle-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @alanhuangch. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesLabel standardization
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR only standardizes labels for an end-to-end test, with no actionable merge-blocking risk remaining beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
===========================================
+ Coverage 71.77% 86.02% +14.25%
===========================================
Files 22 14 -8
Lines 2172 1689 -483
===========================================
- Hits 1559 1453 -106
+ Misses 558 191 -367
+ Partials 55 45 -10 🚀 New features to boost your workflow:
|
Replace non-standard labels (type=reconciliation, scenario=drift-service-selector) with the framework-provided category/speed/scenario labels so the test can be selected by the smoke/extended profiles.
4b435e8 to
0ef0ca8
Compare
Replace non-standard labels (type=reconciliation, scenario=drift-service-selector) with the framework-provided category/speed/scenario labels so the test can be selected by the smoke/extended profiles.
Fixes #320
Summary by CodeRabbit