Skip to content

chore: update go dependencies #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: update go dependencies #1647

wants to merge 3 commits into from
+283 −206

Conversation

slashpai
Copy link
Contributor

updates k8s dependencies to v0.33.0 as well

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@slashpai
chore: update go dependencies
3476db5 
Signed-off-by: Jayapriya Pai <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: slashpai
Once this PR has been reviewed and has the lgtm label, please assign logicalhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 24, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If metrics-server contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Hi @slashpai. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2025
@dgrisonnet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2025
@slashpai
Copy link
Contributor Author

more updates are needed as some of the modules have breaking changes (prometheus one mainly)
working on it

slashpai
slashpai commented Apr 24, 2025
View reviewed changes
pkg/scraper/client/resource/decode.go
@@ -44,7 +44,7 @@ func decodeBatch(b []byte, defaultTime time.Time, nodeName string) (*storage.Met
}
node := &storage.MetricsPoint{}
pods := make(map[apitypes.NamespacedName]storage.PodMetricsPoint)
parser, err := textparse.New(b, "", false, nil)
parser, err := textparse.New(b, "text/plain", "", false, false, nil)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to changes in prometheus/prometheus@421a3c2#diff-88b6f2039c68ed3e6c470170fb60854b4dc7ef381e14c690337e0db8d0a2aab9R138-R139 for v3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgrisonnet Do we want to specify a specific fallback scrape protocol?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any would make sense. Metrics-server always scrapes kubelet's metrics in text format: https://github.com/kubernetes-sigs/metrics-server/blob/master/pkg/scraper/client/resource/client.go#L105-L137

No having any would also keep the same behavior as we had before this change in Prometheus: prometheus/prometheus@421a3c2#diff-88b6f2039c68ed3e6c470170fb60854b4dc7ef381e14c690337e0db8d0a2aab9R138-R141

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, keeping only content type as current change then.

@slashpai slashpai mentioned this pull request Apr 24, 2025
Open
slashpai
slashpai commented Apr 24, 2025
View reviewed changes
cmd/metrics-server/app/options/options.go

serverConfig.EffectiveVersion = utilcompatibility.DefaultBuildEffectiveVersion()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to kubernetes/component-base@77439d2#diff-f6bf0ae0d21c9408c6624174da11dafb369ce306f2cdcea704285d8acc87e19e

@slashpai slashpai mentioned this pull request Apr 24, 2025
Open
@dgrisonnet
Copy link
Member

cc @RainbowMango

This was referenced Apr 25, 2025
Open
Open
@RainbowMango
Copy link
Member

I will look at the ASAP. (Not got a chance to go through the changes of Kubernetes v1.33)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@yangjunmyfm192085 yangjunmyfm192085 Awaiting requested review from yangjunmyfm192085

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slashpai @k8s-ci-robot @dgrisonnet @RainbowMango