Skip to content

Allow configuring NodeSelector and Tolerations for GC#269

Open
yevgeny-shnaidman wants to merge 1 commit into
kubernetes-sigs:masterfrom
yevgeny-shnaidman:yevgeny/gc-node-selector
Open

Allow configuring NodeSelector and Tolerations for GC#269
yevgeny-shnaidman wants to merge 1 commit into
kubernetes-sigs:masterfrom
yevgeny-shnaidman:yevgeny/gc-node-selector

Conversation

@yevgeny-shnaidman

Copy link
Copy Markdown
Contributor

This commit allows configuring node selector and tolerations for GC pod, in order to determine which node it must run on

This commit allows configuring node selector and tolerations for GC pod,
in order to determine which node it must run on
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yevgeny-shnaidman
Once this PR has been reviewed and has the lgtm label, please assign marquiz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2026
@yevgeny-shnaidman

Copy link
Copy Markdown
Contributor Author

/assign @marquiz
/assign @ArangoGutierrez

@yevgeny-shnaidman

Copy link
Copy Markdown
Contributor Author

/assign @marquiz
/assign @ArangoGutierrez

@yevgeny-shnaidman

Copy link
Copy Markdown
Contributor Author

@marquiz can you please take a look?

@marquiz marquiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yevgeny-shnaidman, looks good to me. Apologies for the delay

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2026
@yevgeny-shnaidman

Copy link
Copy Markdown
Contributor Author

@ArangoGutierrez can you also take a look?

@yevgeny-shnaidman

Copy link
Copy Markdown
Contributor Author

Thanks @yevgeny-shnaidman, looks good to me. Apologies for the delay

Thank you @marquiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants