Skip to content

Update Go to 1.24.2 to fix CVE #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
prad9192 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Go to 1.24.2 to fix CVE #567

prad9192 wants to merge 1 commit into from
+44 −44

Conversation

@prad9192
Copy link
Contributor

@prad9192 prad9192 commented Dec 7, 2025

Update Go to 1.24.2 to fix CVE

@netlify
Copy link

netlify bot commented Dec 7, 2025 •
edited
Loading

✅ Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit be4830a
🔍 Latest deploy log https://app.netlify.com/projects/k8s-prow/deploys/6936525c87073b0008ac3a8b
😎 Deploy Preview https://deploy-preview-567--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the area/documentation Issues or PRs related to documentation label Dec 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prad9192
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 7, 2025

Hi @prad9192. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2025
@petr-muller
Copy link
Contributor

petr-muller commented Dec 8, 2025

/test all

petr-muller
petr-muller reviewed Dec 8, 2025
View reviewed changes
site/go.mod
Comment on lines 5 to 8
require (
github.com/google/docsy v0.12.0 // indirect
github.com/google/docsy/dependencies v0.7.2 // indirect
)
Copy link
Contributor

@petr-muller petr-muller Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

Copy link
Contributor Author

@prad9192 prad9192 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh go mod tidy might have removed them, let me check

Copy link
Contributor Author

@prad9192 prad9192 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the removed dependencies.
I updated the PR to address your feedback

prad9192
prad9192 commented Dec 9, 2025
View reviewed changes
Copy link
Contributor Author

@prad9192 prad9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed comments

site/go.mod
Comment on lines 5 to 8
require (
github.com/google/docsy v0.12.0 // indirect
github.com/google/docsy/dependencies v0.7.2 // indirect
)
Copy link
Contributor Author

@prad9192 prad9192 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh go mod tidy might have removed them, let me check

site/go.mod
Comment on lines 5 to 8
require (
github.com/google/docsy v0.12.0 // indirect
github.com/google/docsy/dependencies v0.7.2 // indirect
)
Copy link
Contributor Author

@prad9192 prad9192 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the removed dependencies.
I updated the PR to address your feedback

@stmcginnis
Copy link
Contributor

stmcginnis commented Dec 9, 2025

Not trying to derail anything, but curious if it would be better to just move to 1.25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petr-muller petr-muller petr-muller left review comments

@matthyx matthyx Awaiting requested review from matthyx

Assignees

No one assigned

Labels

area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prad9192 @k8s-ci-robot @petr-muller @stmcginnis