repoowners: add advisory_approvers OWNERS field - #783
Open
smg247 wants to merge 5 commits into
Open
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
kubernetes-prow
Bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
smg247
marked this pull request as ready for review
June 30, 2026 12:58
kubernetes-prow
Bot
removed
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
area/plugins
kubernetes-prow
Bot
requested review from
MadhavJivrajani and
Priyankasaggu11929
June 30, 2026 12:58
kubernetes-prow
Bot
added
the
approved
kubernetes-prow
Bot
added
size/L
Advisory approvers retain /approve power but are excluded from auto-assignment by LeafApprovers. This allows teams to list senior maintainers or leads who should be able to approve but shouldn't be automatically assigned as reviewers.
smg247
force-pushed
the
advisory-approvers
branch
from
June 30, 2026 13:23
d3fc193 to
139ca02
Compare
kubernetes-prow
Bot
added
cncf-cla: yes
JoelSpeed
reviewed
Jul 1, 2026
Drop 'advisory-' prefix from test login names to make clear that list membership determines the advisory role, not naming convention. Remove reviewer/advisory overlap from TestApplyConfigWithAdvisoryApprovers since that case is already covered by TestAdvisoryApproverAlsoReviewer.
Member
|
Shouldn't we update this: https://github.com/kubernetes-sigs/prow/blob/main/pkg/plugins/verify-owners/verify-owners.go#L400 as well? |
Contributor
Author
|
/retest |
Prucek
reviewed
Aug 11, 2026
|
|
||
| // AdvisoryApprovers returns the set of advisory approvers for the requested | ||
| // file. These users retain approval power but are excluded from auto-assignment. | ||
| func (o *RepoOwners) AdvisoryApprovers(path string) sets.Set[string] { |
Member
There was a problem hiding this comment.
This method is never called anywhere
| if existing, ok := o.approvers[path][re]; ok { | ||
| o.approvers[path][re] = existing.Union(advisorySet) | ||
| } else { | ||
| o.approvers[path][re] = advisorySet.Union(sets.New[string]()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advisory approvers retain /approve power but are excluded from auto-assignment by LeafApprovers. This allows teams to list senior maintainers or leads who should be able to approve but shouldn't be automatically assigned as reviewers.
Implements: #784