spyglass/junit: deduplicate test detail row rendering - #785
Open
petr-muller wants to merge 1 commit into
Open
Conversation
Extract a shared "test-detail-rows" sub-template for the expandable test result rows that were duplicated four times across the default failed/flaky and group failed/flaky sections. Unify the CSS class names (failure-*/flaky-*/group-* -> detail-*) and collapse the redundant selectors in junit.css.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
area/spyglass
kubernetes-prow
Bot
added
the
approved
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kubernetes-prow
Bot
added
size/L
Contributor
Author
|
/hold Need to test this |
kubernetes-prow
Bot
added
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract a shared "test-detail-rows" sub-template for the expandable test result rows that were duplicated four times across the default failed/flaky and group failed/flaky sections. Unify the CSS class names (failure-/flaky-/group-* -> detail-*) and collapse the redundant selectors in junit.css.
Assisted by Claude Code