fix(trigger): fall back to rerun when approve fails for non-fork PRs - #798
Open
cblecker wants to merge 2 commits into
Open
fix(trigger): fall back to rerun when approve fails for non-fork PRs#798cblecker wants to merge 2 commits into
cblecker wants to merge 2 commits into
Conversation
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kubernetes-prow
Bot
added
cncf-cla: yes
kubernetes-prow
Bot
requested review from
MadhavJivrajani,
Priyankasaggu11929,
cjwagner and
matthyx
July 14, 2026 22:46
kubernetes-prow
Bot
added
the
approved
The GitHub Actions approve endpoint only works for fork PRs. When a same-repo PR is created by a bot (e.g. github-actions[bot]), workflow runs enter action_required status but the approve endpoint returns 403. Previously this was logged as a token scope warning and silently swallowed. Now when approve returns 403, we fall back to the rerun endpoint which changes the triggering_actor to the API caller and bypasses the approval gate. Also returns a sync.WaitGroup from approveGitHubActionsWorkflowRuns so tests can reliably wait for goroutine completion instead of using time.Sleep.
cblecker
force-pushed
the
fix-ok-to-test-non-fork-approval
branch
from
July 15, 2026 01:49
2193d3c to
dd76a90
Compare
kubernetes-prow
Bot
added
area/deck
Prucek
approved these changes
Aug 10, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cblecker, Prucek The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github-actions[bot]), workflow runs enteraction_requiredstatus but the approve endpoint returns 403. Previously this was logged as a warning about token scopes and silently swallowed, so/ok-to-testappeared to do nothing for GitHub Actions workflows on bot-created PRs.triggering_actorto the API caller and bypasses the approval gate.sync.WaitGroupfromapproveGitHubActionsWorkflowRunsso tests can reliably wait for goroutine completion instead of usingtime.Sleep.References:
Note: this PR was created with the assistance of AI tooling