Skip to content

Add nil guard to publisher.Commit and set GitUser in GithubOptions.GitClientFactory #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StarMiner99 wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −0
Open

Add nil guard to publisher.Commit and set GitUser in GithubOptions.GitClientFactory #801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b57e87d
add nil guard to publisher.info
StarMiner99 Jul 15, 2026
b8eface
set gituser together with gh username
StarMiner99 Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/flagutil/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ func (o *GitHubOptions) GitClientFactory(cookieFilePath string, cacheDir *string
return nil, fmt.Errorf("failed to get git authentication: %w", err)
}
opts.Username = func() (string, error) { return user, nil }
opts.GitUser = func() (string, string, error) { return user, "", nil } // pass empty email, git allows this
opts.Token = generator
}
// If the client is for Gerrit we're already set with the cookie filepath.
Expand Down
3 changes: 3 additions & 0 deletions pkg/git/v2/publisher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ type publisher struct {
// Commit adds all of the current content to the index and creates a commit
func (p *publisher) Commit(title, body string) error {
p.logger.Infof("Committing changes with title %q", title)
if p.info == nil {
return fmt.Errorf("error committing %q: GitUser is not set", title)

@ylink-lfs ylink-lfs Jul 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current the returned error doesn't explain the remedy for developers.

}
name, email, err := p.info()
if err != nil {
return err
Expand Down