override: preserve status base SHA when overriding jobs - #808
override: preserve status base SHA when overriding jobs#808SaaiAravindhRaja wants to merge 1 commit into
Conversation
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SaaiAravindhRaja The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @SaaiAravindhRaja. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
e2d6a6b to
402d33a
Compare
|
hi! is there anything i can improve on? |
|
I am not sure about this; isn't this solving the same issue: #778 ? |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When
/overridehandles a failed presubmit status that already carries aBaseSHA:marker, it now reuses that original base SHA for both the replacement status description and the synthetic successful ProwJob.This avoids replacing the job's original base SHA with the base branch SHA at command time, which can differ if the base branch moved after the job ran.
Which issue(s) this PR fixes:
Part of #789
Special notes for your reviewer:
This keeps the existing synthetic ProwJob behavior intact and only changes the base SHA source used when creating the override result.
Does this PR introduce a user-facing change?