Skip to content

override: preserve status base SHA when overriding jobs - #808

Open
SaaiAravindhRaja wants to merge 1 commit into
kubernetes-sigs:mainfrom
SaaiAravindhRaja:fix/override-base-sha-status
Open

override: preserve status base SHA when overriding jobs#808
SaaiAravindhRaja wants to merge 1 commit into
kubernetes-sigs:mainfrom
SaaiAravindhRaja:fix/override-base-sha-status

Conversation

@SaaiAravindhRaja

@SaaiAravindhRaja SaaiAravindhRaja commented Jul 27, 2026

Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it:

When /override handles a failed presubmit status that already carries a BaseSHA: marker, it now reuses that original base SHA for both the replacement status description and the synthetic successful ProwJob.

This avoids replacing the job's original base SHA with the base branch SHA at command time, which can differ if the base branch moved after the job ran.

Which issue(s) this PR fixes:

Part of #789

Special notes for your reviewer:

This keeps the existing synthetic ProwJob behavior intact and only changes the base SHA source used when creating the override result.

Does this PR introduce a user-facing change?

NONE

@kubernetes-prow kubernetes-prow Bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 27, 2026
@netlify

netlify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 402d33a
🔍 Latest deploy log https://app.netlify.com/projects/k8s-prow/deploys/6a6a20bf4754bc0008e9e30a
😎 Deploy Preview https://deploy-preview-808--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from cjwagner July 27, 2026 07:58
@kubernetes-prow kubernetes-prow Bot added the area/plugins Issues or PRs related to prow's plugins for the hook component label Jul 27, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SaaiAravindhRaja
Once this PR has been reviewed and has the lgtm label, please assign cjwagner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @SaaiAravindhRaja. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 27, 2026
@ylink-lfs

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2026
@SaaiAravindhRaja
SaaiAravindhRaja force-pushed the fix/override-base-sha-status branch from e2d6a6b to 402d33a Compare July 29, 2026 15:48
@SaaiAravindhRaja

Copy link
Copy Markdown
Author

hi! is there anything i can improve on?

@Prucek

Prucek commented Aug 10, 2026

Copy link
Copy Markdown
Member

I am not sure about this; isn't this solving the same issue: #778 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/plugins Issues or PRs related to prow's plugins for the hook component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants