Fix sticky overrides being clobbered by retriggered ProwJobs - #818
Open
smg247 wants to merge 1 commit into
Open
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
kubernetes-prow
Bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
area/plugins
kubernetes-prow
Bot
requested review from
MadhavJivrajani,
Priyankasaggu11929,
cjwagner and
petr-muller
July 29, 2026 17:41
smg247
marked this pull request as ready for review
July 29, 2026 17:41
kubernetes-prow
Bot
added
approved
kubernetes-prow
Bot
added
the
size/L
Contributor
Author
|
/retest |
petr-muller
reviewed
Jul 30, 2026
petr-muller
left a comment
petr-muller
left a comment
Contributor
There was a problem hiding this comment.
This looks like two separate changes and should be done in two commits (and I'd actually prefer two PRs myself). I think the override doing an abort is trickier than it seems, there needs to be some handover to Plank to terminate the actual workload.
kubernetes-prow
Bot
added
the
do-not-merge/hold
smg247
changed the title
buildAll triggers all auto-run presubmits unconditionally, even when their context already has a successful GitHub status or check run. This wastes resources re-running jobs that have already passed. Fetch combined status and check runs before filtering presubmits, and skip any whose context is already successful. Falls back to running everything if the status fetch fails.
smg247
force-pushed
the
fix/sticky-override-abort-and-skip-passing
branch
from
July 30, 2026 19:52
e9b2c61 to
82e1f16
Compare
Contributor
Author
|
/hold cancel |
kubernetes-prow
Bot
removed
the
do-not-merge/hold
Contributor
|
/cc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues prevent /override-sticky statuses from persisting. This takes care of the issues with
trigger.Trigger plugin: skip presubmits whose context already has a SUCCESS status in buildAll(). Previously, when LGTM was applied to an untrusted PR, buildAll would create new ProwJobs for all presubmits regardless of current status, clobbering sticky overrides when the new jobs completed.