fix(deck): replace gorilla/csrf with net/http.CrossOriginProtection - #843
Open
cblecker wants to merge 1 commit into
Open
fix(deck): replace gorilla/csrf with net/http.CrossOriginProtection#843cblecker wants to merge 1 commit into
cblecker wants to merge 1 commit into
Conversation
Replace github.com/gorilla/csrf v1.7.3 (CVE-2025-47909) with Go stdlib net/http.CrossOriginProtection, available since Go 1.25. CrossOriginProtection uses Origin/Fetch Metadata validation instead of the Synchronizer Token Pattern, so all CSRF token plumbing is removed: cookie-secret derivation for CSRF, token injection into HTML templates, X-CSRF-Token headers in TypeScript, and the csrfToken JS global. CSRF protection is now always-on and requires no configuration. Assisted-by: Claude:claude-opus-4-6
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
area/deck
kubernetes-prow
Bot
added
area/documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/gorilla/csrfv1.7.3 (CVE-2025-47909, medium severity) with Go stdlibnet/http.CrossOriginProtection(available since Go 1.25)X-CSRF-Tokenheaders in TypeScript, and thecsrfTokenJS globalSec-Fetch-SiteandOriginheaders server-side instead of using the Synchronizer Token PatternTest plan
go build ./cmd/deck/...compiles cleango test ./cmd/deck/...passesgo mod tidyremovesgorilla/csrf, retainsgorilla/sessionsandgorilla/securecookiecsrfTokenorgorilla/csrfreferences in the codebase