deck: drop stale Prow-managed contexts with no matching ProwJob - #847
Open
Champbreed wants to merge 1 commit into
Open
deck: drop stale Prow-managed contexts with no matching ProwJob#847Champbreed wants to merge 1 commit into
Champbreed wants to merge 1 commit into
Conversation
❌ Deploy Preview for k8s-prow failed. Why did it fail? →
|
kubernetes-prow
Bot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Champbreed The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
area/deck
Contributor
|
/hold I am not convinced we should do this, posted a #824 (comment) to the issue. |
kubernetes-prow
Bot
added
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops such stale contexts when the name matches Prow's job naming convention (pull-, branch-ci-, ci- prefixes), so non-Prow checks are never touched.
getFullPRContext merges GitHub's reported contexts with Prow's live ProwJob list, but never drops a context GitHub still reports if no matching ProwJob exists for it. This happens when a Prow job is renamed or removed. GitHub keeps the old context indefinitely since nothing tells it to retract it.
Known limitation: this matches by naming convention, not by comparing against Prow's actual job config, so it won't catch a renamed job with a non-standard name. Happy to follow up with a config-based check if that's preferred.
Fixes #824
cc @BenTheElder @petr-muller