fix: status-reconciler track own config state for dropped deltas - #849
fix: status-reconciler track own config state for dropped deltas#849Prucek wants to merge 1 commit into
Conversation
config.Agent.Set() silently drops deltas when the subscriber channel is blocked for over a minute. When this happens, the agent's config advances but the subscriber never receives the notification, making those changes permanently invisible. This was observed in production when status-reconciler spent hours processing a large delta and missed new presubmit additions during that window. Fix status-reconciler to diff against its own lastProcessed config rather than trusting the delta's Before field, so the next delivered delta captures all missed changes. Also log a warning in the config agent when a delta is dropped.
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kubernetes-prow
Bot
added
cncf-cla: yes
kubernetes-prow
Bot
added
the
area/status-reconciler
|
This seems like a flake: pull-prow-unit-test |
|
/test pull-prow-unit-test |
|
/test pull-prow-integration |
|
@kaovilai: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kaovilai, Prucek The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 participants
Summary
config.Agent.Set()silently drops deltas when the subscriber channel is blocked for over a minute. When this happens, the agent's config advances but the subscriber never sees the notification, making those changes permanently invisible tostatus-reconciler.status-reconcilerto diff against its ownlastProcessedconfig rather than trusting the delta'sBeforefield, so the next delivered delta captures all missed changes.Fixes #848
Generated with the help of AI (Claude Code)