Skip to content

remove useless scheme in coscheduling client #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove useless scheme in coscheduling client #882

wants to merge 1 commit into from

Conversation

KunWuLuan
Copy link
Member

@KunWuLuan KunWuLuan commented Feb 27, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

image

What this PR does / why we need it:

In #881, I added a cache for client in coscheduling plugin, this may cause listing of core resources like pods and nodes.

Client in coscheduling will only be used to get and list podgroups. Remove these code can save memory by preventing the listing of core resources like pods and nodes any more.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KunWuLuan
Once this PR has been reviewed and has the lgtm label, please assign huang-wei for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 27, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit 1488908
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/67f873c5b042310008da954b

@KunWuLuan KunWuLuan changed the title add Cache to coscheduling plugin remove useless scheme in coscheduling client Feb 27, 2025
ffromani
ffromani reviewed Mar 14, 2025
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing something? this seems the same change as #881 - adding cache

@KunWuLuan
Copy link
Member Author

Am I missing something? this seems the same change as #881 - adding cache

I split that pr to 2 prs, each of them contains one commit.

@Huang-Wei
Copy link
Contributor

Am I missing something? this seems the same change as #881 - adding cache

I had the same question... this PR looks the same as #881.

The changes are valid. Per #881 (comment), @KunWuLuan could you help consolidate changes needed for all plugins in one PR?

@KunWuLuan
Copy link
Member Author

@Huang-Wei @ffromani Sorry I wanted to remove the useless scheme in this pr and it seems that I have some mistakes with the commits. I will correct this pr today.

@KunWuLuan KunWuLuan force-pushed the clean/move-useless-informer branch from cca2c51 to 1488908 Compare April 11, 2025 01:43
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2025
@KunWuLuan
Copy link
Member Author

Because the reason about network, git push failed last time.
I updated the pr. It should be the right commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani ffromani left review comments

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

@zwpaper zwpaper Awaiting requested review from zwpaper

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KunWuLuan @k8s-ci-robot @Huang-Wei @ffromani