add validate for NodeResourcesAllocatable and Coscheduling plugin #888
Conversation
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: googs1025 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
k8s-ci-robot
added
release-note-none
Signed-off-by: googs1025 <[email protected]>
googs1025
force-pushed
the
add_vadlidate_arg
branch
from
51d9d8d to
4d175be
Compare
|
/assign @Huang-Wei |
| var supportNodeResourcesMode = sets.NewString( | ||
| string(config.Least), | ||
| string(config.Most), | ||
| ) |
There was a problem hiding this comment.
this should probably be done in init or similar initialization function
| string(config.Most), | ||
| ) | ||
|
|
||
| func validateNodeResourcesModeType(mode config.ModeType, path *field.Path) *field.Error { |
There was a problem hiding this comment.
if ModeType is an enum-like type (is it right?) how can it be different than the enumerated value? isn't the golang type system preventing this?
| v1 "k8s.io/api/core/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/klog/v2" | ||
| schedulerconfig "k8s.io/kubernetes/pkg/scheduler/apis/config" | ||
| "k8s.io/kubernetes/pkg/scheduler/framework" | ||
|
|
||
| "math" |
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #887
Special notes for your reviewer:
Does this PR introduce a user-facing change?