Skip to content

Fix broken client gen - #2046

Open
stlaz wants to merge 4 commits into
kubernetes-sigs:mainfrom
stlaz:client-gen
Open

Fix broken client gen#2046
stlaz wants to merge 4 commits into
kubernetes-sigs:mainfrom
stlaz:client-gen

Conversation

@stlaz

@stlaz stlaz commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes and runs client codegen.

Which issue(s) this PR fixes
-

Special notes for your reviewer:

Discovered as a part of kubernetes-sigs/secrets-store-sync-controller#186

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 15, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If secrets-store-csi-driver contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stlaz
Once this PR has been reviewed and has the lgtm label, please assign enj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot requested review from aramase and enj June 15, 2026 08:42
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 15, 2026
@codecov-commenter

codecov-commenter commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 298 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.84%. Comparing base (60180a6) to head (c4fb32b).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/client/informers/externalversions/factory.go 0.00% 41 Missing ⚠️
...rs/externalversions/apis/v1/secretproviderclass.go 0.00% 26 Missing ⚠️
...alversions/apis/v1/secretproviderclasspodstatus.go 0.00% 26 Missing ⚠️
...ernalversions/apis/v1alpha1/secretproviderclass.go 0.00% 26 Missing ⚠️
...ions/apis/v1alpha1/secretproviderclasspodstatus.go 0.00% 26 Missing ⚠️
...ned/typed/apis/v1/fake/fake_secretproviderclass.go 0.00% 16 Missing ⚠️
.../apis/v1/fake/fake_secretproviderclasspodstatus.go 0.00% 16 Missing ⚠️
...ped/apis/v1alpha1/fake/fake_secretproviderclass.go 0.00% 16 Missing ⚠️
...v1alpha1/fake/fake_secretproviderclasspodstatus.go 0.00% 16 Missing ⚠️
pkg/client/clientset/versioned/clientset.go 0.00% 15 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
+ Coverage   22.07%   25.84%   +3.76%     
==========================================
  Files          57       57              
  Lines        3198     2724     -474     
==========================================
- Hits          706      704       -2     
+ Misses       2400     1926     -474     
- Partials       92       94       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

stlaz added 3 commits June 15, 2026 11:48
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants