-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete deletion of CnsFileAccessConfig instance if associated nodeVM instance is not found #3151
Complete deletion of CnsFileAccessConfig instance if associated nodeVM instance is not found #3151
Conversation
Hi @vdkotkar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
pkg/syncer/cnsoperator/controller/cnsfileaccessconfig/cnsfileaccessconfig_controller.go
Show resolved
Hide resolved
91af55d
to
8b5cbd7
Compare
d94a9bb
to
35c10d7
Compare
35c10d7
to
0ca04d5
Compare
/test pull-vsphere-csi-driver-unit-test |
pkg/syncer/cnsoperator/controller/cnsfileaccessconfig/cnsfileaccessconfig_controller.go
Outdated
Show resolved
Hide resolved
pkg/syncer/cnsoperator/controller/cnsfileaccessconfig/cnsfileaccessconfig_controller.go
Show resolved
Hide resolved
pkg/internalapis/cnsoperator/cnsfilevolumeclient/cnsfilevolumeclient.go
Outdated
Show resolved
Hide resolved
pkg/syncer/cnsoperator/controller/cnsfileaccessconfig/cnsfileaccessconfig_controller.go
Outdated
Show resolved
Hide resolved
pkg/internalapis/cnsoperator/cnsfilevolumeclient/cnsfilevolumeclient.go
Outdated
Show resolved
Hide resolved
…M instance is not found
0ca04d5
to
7586cba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, vdkotkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR contains following changes:
Updating code to proceed with the deletion of CnsFileAccessConfig instance if the associated nodeVM instance is not found (already deleted). To fetch VM IP which is required to configure ACL, we get it from CnsFileVolumeClient CR.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done:
make check
andmake test
are passing.Verified that namespace deletion is succeeding now when file volume is attached to the pod in namespace.
followed below mentioned steps:
Verify the CRD cnsfileaccessconfigs.cns.vmware.com is created
Logs for reference:
Special notes for your reviewer:
Release note: