Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

management workload domain isolation automation #3158

Merged
merged 1 commit into from
Jan 21, 2025
Merged

management workload domain isolation automation #3158

merged 1 commit into from
Jan 21, 2025

Conversation

sipriyaa
Copy link
Contributor

@sipriyaa sipriyaa commented Jan 16, 2025 •
edited
Loading

What this PR does / why we need it:
This PR holds the utils required to automate the usecass for management workload domain isolation feature.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Includes helper methods and testcases automated for the feature.

Testing done:
Yes

testlogs.txt

Special notes for your reviewer:
sipriya@C02CR8ENMD6M vsphere-csi-driver % golangci-lint run --enable=lll --timeout 10m

sipriya@C02CR8ENMD6M vsphere-csi-driver % make golangci-lint
hack/check-golangci-lint.sh
golangci/golangci-lint info checking GitHub for tag 'v1.59.1'
golangci/golangci-lint info found version: 1.59.1 for v1.59.1/darwin/amd64

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 16, 2025
@sipriyaa sipriyaa force-pushed the domain-isolation-automation branch 3 times, most recently from 69c657a to a2b2c01 Compare January 17, 2025 06:32
@kavyashree-r
Copy link
Contributor

/approve

@sipriyaa sipriyaa force-pushed the domain-isolation-automation branch from e867b7b to 3044c4a Compare January 17, 2025 07:11
@sipriyaa
Copy link
Contributor Author

/retest

@sipriyaa
Copy link
Contributor Author

/retest-required

@sipriyaa sipriyaa force-pushed the domain-isolation-automation branch from 68bad88 to 38077f8 Compare January 17, 2025 07:34
rajguptavm
rajguptavm approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@rajguptavm rajguptavm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavyashree-r, rajguptavm, sipriyaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chethanv28
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

@sipriyaa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-vsphere-csi-driver-unit-test 38077f8 link true /test pull-vsphere-csi-driver-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chethanv28
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2025
@chethanv28 chethanv28 merged commit 21521e2 into kubernetes-sigs:master Jan 21, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajguptavm rajguptavm rajguptavm approved these changes

@deepakkinni deepakkinni Awaiting requested review from deepakkinni

@kavyashree-r kavyashree-r Awaiting requested review from kavyashree-r

Assignees

@chethanv28 chethanv28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sipriyaa @kavyashree-r @k8s-ci-robot @chethanv28 @rajguptavm