Replace sigs.k8s.io/release-sdk with underlying github library #1211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're running into this issue in zeitgeist:
```
FATA error during command execution: &fmt.wrapError{msg:"dependency zeitgeist: retrieving GitHub repository: getting repository: json: cannot unmarshal array into Go struct field Repository.custom_properties of type string", err:(*fmt.wrapError)(0x14000343ce0)} file="zeitgeist/main.go:31"
```
This is a known issue with github.com/google/go-github/v60, cf:
google/go-github#3230
The github functionality is provided by sigs.k8s.io/release-sdk, which
includes the github library above, ubt even the latest version only
includes go-github/v60.
Given we're only using the github functionality from the release-sdk,
let's pull the release-sdk out and switch to using only the underlying
go library, which we also update here to fix the bug.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Pluies The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
We're running into this issue in zeitgeist:
This is a known issue with github.com/google/go-github/v60, cf: google/go-github#3230
The github functionality is provided by sigs.k8s.io/release-sdk, which includes the github library above, ubt even the latest version only includes go-github/v60.
Given we're only using the github functionality from the release-sdk, let's pull the release-sdk out and switch to using only the underlying go library, which we also update here to fix the bug.
Which issue(s) this PR fixes:
Special notes for your reviewer:
cc @cpanato for sanity-check, I'm also open to bumping sigs.k8s.io/release-sdk with the correct version but it's more effort and I'm lazy :)
Does this PR introduce a user-facing change?