Only respect prevent argument until connected #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once we're connected, either explicitly or due to to the button click, we should no longer respect the prevent option or reconnect when it cycles.
Closed
1 task
|
@petervo Could you review? |
|
@petervo: Friendly ping, to unblock cockpit-project/cockpit#7687 ? |
|
@martinpitt I don't have merge permissions here. But i'm fine with changes |
|
Neither have I. It's surprisingly difficult to determine who actually has push privs in a GitHub project.. |
spadgett
reviewed
Jan 29, 2018
| @@ -105,6 +105,9 @@ | |||
| var defaultCols = 80; | |||
| var defaultRows = 24; | |||
|
|
|||
| /* Whether the component is preventing a connection */ | |||
| var preventing = true; | |||
There was a problem hiding this comment.
The change looks fine, but the var name is a bit confusing (particularly because we have a scope var called prevent). Can we call this something like connectionRequested or overridePrevent and flip the logic? I think it would make the intent more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we're connected, either explicitly or due to to the button
click, we should no longer respect the prevent option or reconnect
when it cycles.