-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(issue-7071): added verbosity levels #7179
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: ivan katliarchuk <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ivankatliarchuk. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: ivan katliarchuk <[email protected]>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
still relevant |
What type of PR is this?
/kind feature
What this PR does / why we need it:
At the moment there are way too many logs for a verbosity level 0 and 1. Some of the logs appear on action start and end, this is not required. As well as some logs a warning, when they not really warn about anything and just an information. Wrapped warm level logs.
Please let me know if logging at lower verbosity is an ok approach
Which issue(s) this PR fixes:
resolves #7071
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Addev minimun verbosity level 4 for some of the spam logs
Current docs reccomend to set verbosity to lvl 4 to get extra logging
