[cluster-autoscaler-release-1.29] fix: correctly set the default refresh period for VMSS size (used for Spot instances) #7582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
approved
Contributor
Author
|
/cc @tallaxes |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: comtalyst, tallaxes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
merged commit f160b1d
into
kubernetes:cluster-autoscaler-release-1.29
6 of 7 checks passed
aagusuab
pushed a commit
to Azure/autoscaler
that referenced
this pull request
Oct 21, 2025
…the default refresh period for VMSS size (used for Spot instances) **What type of PR is this?** (bug, cleanup, documentation, feature) Bug **What this PR does / why we need it?**: Cherry-pick of kubernetes#7582 **Does this PR introduce a user-facing change?** **WorkItem** <!--- NOTE: REPLACE THIS LINE WITH THE WORKITEM SUFFIXED WITH "https://dev.azure.com/msazure/CloudNativeCompute". Currently, this CAS repo is under "https://dev.azure.com/AzureContainerUpstream", workItems are under "https://dev.azure.com/msazure/CloudNativeCompute" and ADO doesn't support cross-linking.----> **Testing** - [X] Unit tests - [ ] E2E tests (we can custom branches on standalone env only) - [ ] Other tests (eg. manual testing). <details> <summary>Cherry-pick details</summary> **Is this a cherry-picked PR?** - [X] Yes. Include original PR. ``` kubernetes#7582 ``` - [ ] No. On which internal versions / branches is this PR getting cherry-picked ? ``` ``` **Is this PR getting merged on [upstream](https://github.com/kubernetes/autoscaler) ?** - [X] Yes. Which branches / versions including master? ``` All (already done) ``` - [ ] No. Why? ``` ``` </details> <br> **Special notes for your reviewer**: **Additional Documentation**: ---- #### AI description (iteration 1) #### PR Classification Bug fix #### PR Summary This pull request fixes the default refresh period setting for VMSS size, which is used for Spot instances in the Azure cloud provider. - `cluster-autoscaler/cloudprovider/azure/azure_manager_test.go`: Corrected the `getVmssSizeRefreshPeriod` to use the `refreshInterval` directly. - `cluster-autoscaler/cloudprovider/azure/azure_scale_set.go`: Updated the `getVmssSizeRefreshPeriod` to use the `refreshInterval` directly instead of converting it to seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Cherry-pick of #7579. Automated cherry-pick has failed due to cross-version code difference from a new feature.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: