Enforce provisioning requests processing even if all pods are new #7688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
macsko
force-pushed
the
enforce_provisioning_request_processing_even_if_all_pods_are_young
branch
2 times, most recently
from
dd6ffe4 to
b9f4196
Compare
macsko
force-pushed
the
enforce_provisioning_request_processing_even_if_all_pods_are_young
branch
from
b9f4196 to
d7c325a
Compare
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleksandra-malinowska, macsko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Successful processing of ProvisioningRequests can happen when
len(readyNodes) >= a.MaxNodesTotal. Moreover, ProvisioningRequests' pods may have been incorrectly filtered byallPodsAreNew(those pods exists virtually and shouldn't be taken into consideration). This PR adds a new processor:ScaleUpEnforcer, which, depending on unschedulablePods, decides whether the scaleUp action should be forced, bypassing two mentioned checks.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: