VPA: (InPlaceOrRecreate) Allow admission-controller to validate in-place spec #7961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/M
|
Depends on #7934 to merge for unit tests to pass. |
This was referenced Mar 22, 2025
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
The one test failure seems to be legitimate |
maxcao13
force-pushed
the
in-place-updates-admission
branch
3 times, most recently
from
6bff3ef to
8920984
Compare
|
/cc @raywainman |
raywainman
reviewed
Mar 25, 2025
vertical-pod-autoscaler/pkg/admission-controller/resource/vpa/handler_test.go
Outdated
Show resolved
Hide resolved
vertical-pod-autoscaler/pkg/admission-controller/resource/vpa/handler_test.go
Outdated
Show resolved
Hide resolved
|
2 quick test nits and then this is good to go, thanks Max! |
Only allow VPA objects with InPlaceOrRecreate update mode to be created if InPlaceOrRecreate feature gate is enabled. If a VPA object already exists with this mode on, and the feature gate is disabled, this prevents further objects to be created with InPlaceOrRecreate, but this does not prevent the existing InPlaceOrRecreate VPA objects with from being modified. Signed-off-by: Max Cao <[email protected]>
maxcao13
force-pushed
the
in-place-updates-admission
branch
from
8920984 to
a0cf017
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxcao13, raywainman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
This was referenced May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Only allow VPA objects with
InPlaceOrRecreateupdate mode to be created ifInPlaceOrRecreatefeature gate is enabled. If a VPA object already exists with this mode on, and the feature gate is disabled, this prevents further objects to be created withInPlaceOrRecreate, but this does not prevent the existingInPlaceOrRecreateVPA objects with from being modified.Which issue(s) this PR fixes:
Part of AEP-4016 (InPlaceVerticalScaling/InPlaceOrRecreate)
This PR is part of the larger feature PR in #7673
Depends on: #7934
Note that this PR is merging into the in-place-updates feature branch, which will be merged when this feature is all reviewed and ready.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: