-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Fix typos in the metric name for VPA In-Place update #8122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in the metric name for VPA In-Place update #8122
Conversation
Signed-off-by: Tsubasa Nagasawa <[email protected]>
|
Welcome @toVersus! |
|
Hi @toVersus. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey, toVersus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I know this was merged already, but can someone explain the typo? |
|
It's changing the upper case "u" in |
Ohh, I see. For some reason, I thought it was changing from lowercase to uppercase and that's why I got confused 😄. Thanks! |
|
Haha, I was very nervous when you were asking, making me wonder if we missed something that you did intentionally |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I was looking over a recently merged #8115 and found a few typos in the metric names.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: