Feat: partitionable devices support #8559
Conversation
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
area/provider/kwok
k8s-ci-robot
added
area/vertical-pod-autoscaler
needs-rebase
|
Hi @MenD32. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/XXL
MenD32
force-pushed
the
feat/partitionable-devices-support
branch
from
ba8303d to
4fa5202
Compare
k8s-ci-robot
removed
area/provider/aws
|
/remove-kind api-change |
k8s-ci-robot
removed
the
kind/api-change
Signed-off-by: MenD32 <[email protected]>
MenD32
force-pushed
the
feat/partitionable-devices-support
branch
from
65297e3 to
fb70fa4
Compare
| numUnallocated := float64(len(unallocated)) | ||
| return numAllocated / (numAllocated + numUnallocated) | ||
| func calculatePoolUtil(unallocated, allocated []resourceapi.Device, resourceSlices []*resourceapi.ResourceSlice) float64 { | ||
| TotalConsumedCounters := map[string]map[string]resource.Quantity{} |
There was a problem hiding this comment.
nit: totalConsumedCounters?
Having a capitalized name immediately makes me thinking that it's a global exported variable
| numAllocated := float64(len(allocated)) | ||
| numUnallocated := float64(len(unallocated)) | ||
| return numAllocated / (numAllocated + numUnallocated) | ||
| func calculatePoolUtil(unallocated, allocated []resourceapi.Device, resourceSlices []*resourceapi.ResourceSlice) float64 { |
There was a problem hiding this comment.
Can we add a comment explaining how we calculate utilization? Previously it was very easy to reason about its behaviour, right now it's not obvious without throughly reading it
| Driver: driverName, | ||
| NodeName: &nodeName, | ||
| Pool: resourceapi.ResourcePool{Name: poolName, Generation: int64(poolGen), ResourceSliceCount: 1}, | ||
| Devices: devices, |
There was a problem hiding this comment.
Devices and shared counters should be isolated in two separate resource slice objects as per KEP:
The SharedCounters field is mutually exlusive with the Devices field, meaning that SharedCounters must always be specified in a different ResourceSlice than devices consuming the counters. They must however be in the same resource pool with the same Generation. The value in Spec.Pool.ResourceSliceCount should include all ResourceSlices in the pool, regardless of whether they include devices, counter sets or neither.
I think that doing tests with hybrid objects would work, but it won't represent the real entities we would be able to get from the API and we may miss some bugs. Would you mind switching to having two separate resource slice objects having devices and shared counters? As I see in the current implementation - this doesn't seem to be the gap, but it may be beneficial in the long run
There was a problem hiding this comment.
nice catch! I'll fix the tests
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
k8s-ci-robot
added
size/XL
…counters in testResourceSlicesWithPartionableDevices Signed-off-by: MenD32 <[email protected]>
9 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds support for partitionable devices when calculating DRA utilization
Which issue(s) this PR fixes:
Fixes #8053
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: