VPA helm chart: fix tls secret filenames and cluster role perms for admission controller

[jholm117]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #8940 and #8938

Also this fixes a separate issue where the admission controller is missing mutatingwebhookconfigurations perms.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jholm117
Once this PR has been reviewed and has the lgtm label, please assign omerap12 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/charts/vertical-pod-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @jholm117!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jholm117. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[scraly]

Are you sure?

I edited my secret to fix the installation and I have an error:

F1216 07:58:04.419593       1 config.go:89] open /etc/tls-certs/serverCert.pem: no such file or directory

[jholm117]

It sounds like the secret is not getting mounted properly for you, but this log message confirms the filename should be serverCert.pem

[omerap12]

Thanks for this. but we have a different approach here that drops this secret completely. please feel free to review it.

[jholm117]

Thanks for this. but we have a different approach here that drops this secret completely. please feel free to review it.

Oh hadn't seen that. Should I close this and reopen one with the cluster role changes only?

[omerap12]

Thanks for this. but we have a different approach here that drops this secret completely. please feel free to review it.

Oh hadn't seen that. Should I close this and reopen one with the cluster role changes only?

I don't think it necessary since I already fix it in that PR.

[jholm117]

Thanks for this. but we have a different approach here that drops this secret completely. please feel free to review it.

Oh hadn't seen that. Should I close this and reopen one with the cluster role changes only?

I don't think it necessary since I already fix it in that PR.

Okay, it sounds like I should close this then

[omerap12]

Thanks for this. but we have a different approach here that drops this secret completely. please feel free to review it.

Oh hadn't seen that. Should I close this and reopen one with the cluster role changes only?

I don't think it necessary since I already fix it in that PR.

Okay, it sounds like I should close this then

Yes, I think so (sorry).
/close

[k8s-ci-robot]

@omerap12: Closed this PR.

Details

In response to this:

Thanks for this. but we have a different approach here that drops this secret completely. please feel free to review it.

Oh hadn't seen that. Should I close this and reopen one with the cluster role changes only?

I don't think it necessary since I already fix it in that PR.

Okay, it sounds like I should close this then

Yes, I think so (sorry).
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.