Skip to content

Report proper metrics value when node became needed again #8972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ttetyanka wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Report proper metrics value when node became needed again #8972

ttetyanka wants to merge 1 commit into from
+39 −26

Conversation

@ttetyanka
Copy link
Contributor

@ttetyanka ttetyanka commented Dec 23, 2025 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

We need it to avoid unnecessary items in node_removal_latency_seconds with deleted=false, currently we emit incorrect value (without unneeded/unready threshold)

Which issue(s) this PR fixes:

Provides proper values for node_removal_latency_seconds, when node became needed again

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes an issue where `node_removal_latency_seconds` reported incorrect values (missing the unneeded/unready threshold) when a previously unneeded node became needed again.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/cluster-autoscaler do-not-merge/needs-area labels Dec 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 23, 2025

Hi @ttetyanka. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ttetyanka
Once this PR has been reviewed and has the lgtm label, please assign bigdarkclown for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 23, 2025
@ttetyanka
Copy link
Contributor Author

ttetyanka commented Dec 23, 2025

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 23, 2025
x13n
x13n reviewed Dec 31, 2025
View reviewed changes
Copy link
Member

@x13n x13n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes behavior of the metric, so I think it makes sense to mention this bugfix there.

cluster-autoscaler/core/scaledown/latencytracker/node_latency_tracker.go Outdated
if info, exists := t.unneededNodes[nodeName]; exists {
duration := time.Since(info.unneededSince)
metrics.UpdateScaleDownNodeRemovalLatency(false, duration)
latency := duration - info.removalThreshold
Copy link
Member

@x13n x13n Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost identical to the other block of code below. Perhaps an opportunity to remove some duplication?

@ttetyanka ttetyanka force-pushed the feature/fix_latency_metrics branch from a4aa479 to 1aa019f Compare December 31, 2025 16:22
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@x13n x13n x13n left review comments

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@vadasambar vadasambar Awaiting requested review from vadasambar

Assignees

No one assigned

Labels

area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ttetyanka @k8s-ci-robot @x13n