-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Switch to the maintained official JMESPath Go library #8983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: RainbowMango <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR replaces the unmaintained github.com/jmespath/go-jmespath library with the actively maintained github.com/jmespath-community/go-jmespath library to improve supply chain health and reduce security risks from stale dependencies.
- Updated Go module dependencies to use the community-maintained JMESPath library
- Updated all import statements across Alicloud and Volcengine SDK integrations
- Updated Dependabot configuration to track the new library
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cluster-autoscaler/go.mod | Replaced direct dependency with new maintained library; old library remains as indirect dependency |
| cluster-autoscaler/go.sum | Added checksums for new library version v1.1.1; kept old library entries for transitive dependencies |
| cluster-autoscaler/cloudprovider/volcengine/volcengine-go-sdk/volcengine/volcengineutil/path_value.go | Updated import to use new JMESPath library |
| cluster-autoscaler/cloudprovider/alicloud/alibaba-cloud-sdk-go/sdk/errors/server_error.go | Updated import to use new JMESPath library |
| cluster-autoscaler/cloudprovider/alicloud/alibaba-cloud-sdk-go/sdk/endpoints/local_regional_resolver.go | Updated import to use new JMESPath library |
| cluster-autoscaler/cloudprovider/alicloud/alibaba-cloud-sdk-go/sdk/endpoints/local_global_resolver.go | Updated import to use new JMESPath library |
| cluster-autoscaler/cloudprovider/alicloud/alibaba-cloud-sdk-go/sdk/auth/signers/signer_ram_role_arn.go | Updated import to use new JMESPath library |
| cluster-autoscaler/cloudprovider/alicloud/alibaba-cloud-sdk-go/sdk/auth/signers/signer_oidc.go | Updated import to use new JMESPath library |
| cluster-autoscaler/cloudprovider/alicloud/alibaba-cloud-sdk-go/sdk/auth/signers/signer_key_pair.go | Updated import to use new JMESPath library |
| cluster-autoscaler/cloudprovider/alicloud/alibaba-cloud-sdk-go/sdk/auth/signers/signer_ecs_ram_role.go | Updated import to use new JMESPath library |
| .github/dependabot.yml | Updated to ignore the new library name in dependency updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
jmespath.Search, so no behavior change expected.This helps supply chain health:
jmespath-communitymodule is the officially maintained JMESPath Go library with ongoing releases, CI, linting, and dependency/security updates.` Staying on an actively maintained upstream reduces exposure to latent CVEs, stale transitive deps, and future proxy or archival risks.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: