Add --in-place-skip-disruption-budget flag #8987
Conversation
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omerap12 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/XL
| return &r | ||
| } | ||
|
|
||
| func (pb *podBuilderImpl) WithContainerResizePolicy(containerName string, resizePolicy []apiv1.ContainerResizePolicy) PodBuilder { |
There was a problem hiding this comment.
Does it not make sense to add this to the containerBuilder struct?
Somewhere here: https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/pkg/utils/test/test_container.go
There was a problem hiding this comment.
I actually started adding this to the containerBuilder struct, but then I thought it might be unnecessary in the future. That said, since you mentioned it, it probably does make sense to include it.
There was a problem hiding this comment.
Yeah, makes much more sense. done :)
| inPlaceSkipDisruptionBudget = flag.Bool( | ||
| "in-place-skip-disruption-budget", | ||
| false, | ||
| "If true, VPA updater skips disruption budget checks for in-place pod updates when all containers have NotRequired resize policy or no policy. "+ | ||
| "Disruption budgets are still respected when any container has RestartContainer resize policy.", | ||
| ) | ||
|
|
There was a problem hiding this comment.
I think we might have to say that it only skips if all containers have NotRequired for both cpu and memory resources as well.
| // TODO(omerap12): do we want to check here for InitContainers/InitContainers+restartPolicy Always/ | ||
| // Also check init containers if they can be resized |
There was a problem hiding this comment.
What's the reason to specially handle this?
There was a problem hiding this comment.
Currently the VPA does not support native sidecar (ref: #7229) so in the current implementation I am not checking those
omerap12
force-pushed
the
issue-8980
branch
2 times, most recently
from
00d9e72 to
3f857bf
Compare
Signed-off-by: Omer Aplatony <[email protected]>
4 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds
--in-place-skip-disruption-budgetflag that skips disruption budget checks for in-place pod updates when all containers have NotRequired resize policy. This allows non-disruptive in-place updates to proceed without being throttled by eviction tolerance, while still respecting disruption budgets for RestartContainer resize policy.Which issue(s) this PR fixes:
Fixes #8980
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: