-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Exclude VPA from deprecated golint since it uses golangci-lint #8989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Exclude VPA from deprecated golint since it uses golangci-lint #8989
Conversation
VPA component has migrated to golangci-lint with its own .golangci.yaml config and dedicated GitHub Actions workflow (vpa-golangci-lint.yaml). This change excludes VPA packages from the deprecated golint script to avoid redundant linting with the deprecated tool. Signed-off-by: majiayu000 <[email protected]>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @majiayu000! |
|
Hi @majiayu000. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: majiayu000 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Sorry for not mentioning this in my issue I created, but currently golangci-lint isn't configured for the "exported function should have comment" rule that golint is configured for, so that needs fixing before we can disable golint |
Fixes #8986
Changes
Rationale
VPA component has migrated to golangci-lint. Excluding VPA from the deprecated golint script avoids redundant linting with the deprecated tool.