Skip to content

Refactor the recommender to allow for integration tests - With envtest #8992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
adrianmoisey wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Refactor the recommender to allow for integration tests - With envtest #8992

adrianmoisey wants to merge 6 commits into from
+1,505 −376

Conversation

@adrianmoisey
Copy link
Member

@adrianmoisey adrianmoisey commented Jan 3, 2026

Draft PR demonstrating what envtest would look like, reference: #8985

@adrianmoisey
Refactor updater's flags
288990b 
Configure a struct that can be passed around, and populate that with
CLI flags
@adrianmoisey
Move recommender start into it's own module
b02f555
@adrianmoisey
Add some integration tests
f8a318c
@adrianmoisey
Wire up context, add stop channels, etc
073d75c
@adrianmoisey
Lint
f97b368 
if block ends with a return statement, so drop this else and outdent its block
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 3, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 3, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 3, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 3, 2026
@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-area labels Jan 3, 2026
@adrianmoisey adrianmoisey mentioned this pull request Jan 3, 2026
Open
@adrianmoisey adrianmoisey force-pushed the adrian-integration-tests-envtest branch 4 times, most recently from 64fa0b6 to 733fae5 Compare January 3, 2026 13:31
@adrianmoisey
Switch to envtest
0c219a3 
Thanks to Github Copilot
@adrianmoisey adrianmoisey force-pushed the adrian-integration-tests-envtest branch from 733fae5 to 0c219a3 Compare January 3, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raywainman raywainman Awaiting requested review from raywainman

@voelzmo voelzmo Awaiting requested review from voelzmo

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adrianmoisey @k8s-ci-robot