[VPA] Enable multiple revive rules - 4 by mayuka-c · Pull Request #9155 · kubernetes/autoscaler

mayuka-c · 2026-02-01T06:18:09Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Enables multiple revive rules.
Below are the revive linter rules enabled as part of this PR
- name: redefines-builtin-id
- name: redundant-import-alias

Which issue(s) this PR fixes:

Updates #8986

Special notes for your reviewer:

Continuation from this PR.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2026-02-01T06:18:19Z

Hi @mayuka-c. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mayuka-c · 2026-02-01T06:19:05Z

/cc @adrianmoisey @omerap12

mayuka-c · 2026-02-01T06:19:53Z

vertical-pod-autoscaler/pkg/admission-controller/resource/pod/handler_test.go

 	admissionv1 "k8s.io/api/admission/v1"
 	apiv1 "k8s.io/api/core/v1"
-	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"


Based on the comments here, have enabled the "redundant-import-alias" rule

k8s-triage-robot · 2026-02-01T06:31:37Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

adrianmoisey · 2026-02-01T10:37:36Z

Hmmm, I guess the generated files should be excluded from the linting

mayuka-c · 2026-02-04T14:31:40Z

Hmmm, I guess the generated files should be excluded from the linting

Yes right. Currently I have not changed anything in generated files (Didnt face any lint rule issues) for now. Maybe later we can try excluding linter rules on Generated file?

mayuka-c · 2026-02-04T14:37:44Z

@adrianmoisey @omerap12 Have rebased the PR. PTAL

adrianmoisey · 2026-02-07T18:27:31Z

/ok-to-test

adrianmoisey · 2026-02-07T18:31:21Z

vertical-pod-autoscaler/pkg/admission-controller/resource/vpa/handler.go

 	"fmt"

-	v1 "k8s.io/api/admission/v1"
-	corev1 "k8s.io/api/core/v1"


I'm taking a look at the kubernetes repo, and it seems that this package is often called corev1, any reason why this changes to apiv1 ?

When I looked across the repo, most of the places we have used apiv1, so I have used this to make it consistent.
PLMK if we want to have corev1

corev1 would be great, thanks

WIll be making the changes, Thanks!

Done made the updates

adrianmoisey · 2026-02-07T18:34:24Z

vertical-pod-autoscaler/pkg/admission-controller/resource/handler.go

 	"context"

-	v1 "k8s.io/api/admission/v1"
+	apiv1 "k8s.io/api/admission/v1"


Should this be admissionv1 ?

oops my bad, I will update it

adrianmoisey · 2026-02-15T12:13:00Z

So this change is huge, but something I really want merged. It's likely that when this PR lands, many other PRs will require a rebase, I chatted a bit to Omer about this, and we decided to only merge this after the CPU boost PR has landed. That PR has been in the works for a while now and is code complete, so it should be merged in the next day or two.

This may cause merge conflicts on your PR (sorry about that!), but we can try get it merged in after that.

mayuka-c · 2026-02-17T06:33:27Z

Looks like few things got messed up while rebasing, let me try to fix it

mayuka-c · 2026-02-17T07:17:25Z

@adrianmoisey PR is ready!
I have rebased with the latest CPU boost commits and fixed the lints with all latest changes.

adrianmoisey · 2026-02-17T08:11:54Z

Let's do it!

/lgtm

/cc @omerap12

omerap12

/approve

adrianmoisey · 2026-02-17T08:14:44Z

/approve

(for hack/OWNERS)

k8s-ci-robot · 2026-02-17T08:14:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey, mayuka-c, omerap12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~hack/OWNERS~~ [adrianmoisey]
~~vertical-pod-autoscaler/OWNERS~~ [adrianmoisey,omerap12]
~~vertical-pod-autoscaler/pkg/apis/OWNERS~~ [adrianmoisey,omerap12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed do-not-merge/needs-area labels Feb 1, 2026

k8s-ci-robot requested review from raywainman and smarterclayton February 1, 2026 06:18

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 1, 2026

k8s-ci-robot requested review from adrianmoisey and omerap12 February 1, 2026 06:19

mayuka-c commented Feb 1, 2026

View reviewed changes

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 1, 2026

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2026

mayuka-c force-pushed the add-revive-rules-part4 branch from c9230c9 to 18a813a Compare February 4, 2026 14:30

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2026

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2026

adrianmoisey reviewed Feb 7, 2026

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2026

mayuka-c force-pushed the add-revive-rules-part4 branch from 184ab59 to 9acace5 Compare February 17, 2026 06:29

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 17, 2026

mayuka-c force-pushed the add-revive-rules-part4 branch from 9acace5 to 34c5c9b Compare February 17, 2026 06:35

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2026

mayuka-c added 5 commits February 17, 2026 12:12

[VPA] Enable multiple revive rules - 4

3809380

run codegen

8882614

Lint fix

b19e515

Include importAs and updates

9cfbc19

Ignore spell check for VPA golangci

64db58d

mayuka-c force-pushed the add-revive-rules-part4 branch from 34c5c9b to 64db58d Compare February 17, 2026 06:56

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2026

mayuka-c added 2 commits February 17, 2026 12:38

Fix lints for new changes after rebase

34373a1

Fix importas in golangci

1c0ca03

k8s-ci-robot assigned adrianmoisey Feb 17, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2026

omerap12 approved these changes Feb 17, 2026

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2026

k8s-ci-robot merged commit 068565c into kubernetes:master Feb 17, 2026
13 checks passed

mayuka-c deleted the add-revive-rules-part4 branch February 17, 2026 09:49

Conversation

mayuka-c commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Feb 1, 2026

Uh oh!

mayuka-c commented Feb 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented Feb 1, 2026

Uh oh!

adrianmoisey commented Feb 1, 2026

Uh oh!

mayuka-c commented Feb 4, 2026

Uh oh!

mayuka-c commented Feb 4, 2026

Uh oh!

adrianmoisey commented Feb 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adrianmoisey commented Feb 15, 2026

Uh oh!

mayuka-c commented Feb 17, 2026

Uh oh!

mayuka-c commented Feb 17, 2026

Uh oh!

adrianmoisey commented Feb 17, 2026

Uh oh!

omerap12 left a comment

Choose a reason for hiding this comment

Uh oh!

adrianmoisey commented Feb 17, 2026

Uh oh!

k8s-ci-robot commented Feb 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mayuka-c commented Feb 1, 2026 •

edited

Loading