Skip to content

update builder Dockerfile to go 1.25#9190

Open
jackfrancis wants to merge 1 commit intokubernetes:masterfrom
jackfrancis:builder-dockerfile-go1.25
Open

update builder Dockerfile to go 1.25#9190
jackfrancis wants to merge 1 commit intokubernetes:masterfrom
jackfrancis:builder-dockerfile-go1.25

Conversation

@jackfrancis
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

builder Dockerfile needs to be in sync with the version of go in CA to avoid errors like this:

docker build --network=default -t autoscaling-builder ../builder
[+] Building 0.8s (9/9) FINISHED                                                                                                                                                                                                    docker:desktop-linux
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                0.0s
 => => transferring dockerfile: 891B                                                                                                                                                                                                                0.0s
 => [internal] load metadata for docker.io/library/golang:1.24.0                                                                                                                                                                                    0.8s
 => [internal] load .dockerignore                                                                                                                                                                                                                   0.0s
 => => transferring context: 2B                                                                                                                                                                                                                     0.0s
 => [1/5] FROM docker.io/library/golang:1.24.0@sha256:3f7444391c51a11a039bf0359ee81cc64e663c17d787ad0e637a4de1a3f62a71                                                                                                                              0.0s
 => CACHED [2/5] RUN apt-get update && apt-get --yes install libseccomp-dev                                                                                                                                                                         0.0s
 => CACHED [3/5] RUN go version                                                                                                                                                                                                                     0.0s
 => CACHED [4/5] RUN go install github.com/tools/godep@latest                                                                                                                                                                                       0.0s
 => CACHED [5/5] RUN godep version                                                                                                                                                                                                                  0.0s
 => exporting to image                                                                                                                                                                                                                              0.0s
 => => exporting layers                                                                                                                                                                                                                             0.0s
 => => writing image sha256:b12ab89e28ee22476e7a17f018e989de83d62a2ab61435e8b1d078f178af4298                                                                                                                                                        0.0s
 => => naming to docker.io/library/autoscaling-builder                                                                                                                                                                                              0.0s

 3 warnings found (use docker --debug to expand):
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 17)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 18)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 19)

View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/gv0wf29wrz5g7wutnic4i7xsh
rm -f cluster-autoscaler-amd64
docker run  -v `pwd`:/gopath/src/k8s.io/autoscaler/cluster-autoscaler/:Z autoscaling-builder:latest \
		bash -c 'cd /gopath/src/k8s.io/autoscaler/cluster-autoscaler && BUILD_TAGS= LDFLAGS="-s" make build-arch-amd64'
rm -f cluster-autoscaler-amd64
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o cluster-autoscaler-amd64 --ldflags="-s" 
go: go.mod requires go >= 1.25.0 (running go 1.24.0; GOTOOLCHAIN=local)
make: *** [Makefile:48: build-arch-amd64] Error 1
make: *** [build-in-docker-arch-amd64] Error 2

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/needs-area labels Feb 5, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2026
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 5, 2026
@jackfrancis
Copy link
Contributor Author

/area cluster-autoscaler

@jackfrancis
Copy link
Contributor Author

/cherry-pick cluster-autoscaler-release-1.35

@k8s-infra-cherrypick-robot

@jackfrancis: once the present PR merges, I will cherry-pick it on top of cluster-autoscaler-release-1.35 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants