PR#9357 Backport for 1.34: Ensure HasInstance and NodeGroupForNode derive from the same list, backport ignore string case#9383
Open
jlamillan wants to merge 4 commits intokubernetes:cluster-autoscaler-release-1.34from
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlamillan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…easier troubleshooting.
…event mismatches.
This fixes an issue where existing nodes would be categorized as upcoming. When the cluster state was updated and HasInstance was called, this function would be invoked to check the instance state. The OCI API for instance pools actually returns "Running" (instead of the expected "RUNNING"); this would cause the instance to be flagged as 'Deleted' in the readiness state, and when the calculation for newNodes was made, since a running node belonging to the pool instance was counted as deleted and not registered, the upcoming node count was incorrectly non-zero.
2ca7d9c to
b345466
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
cluster-autoscaler (OCI provider code)
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
This PR adds a fix to
HasInstance()to ensure that it andNodeGroupForNodederive their instance lists the same way for consistent lifecycle mapping. It also adds a number of other incremental updates and other improvements to the OCI (Instance-Pool) cloud provider after attempting to debug the issue:Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I am the original author of the provider code in question and listed in the OWNERS file.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: