Skip to content

Fix:flaky CA E2E test "shouldn't trigger additional scale-ups" #9465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yashrajshuklaaa wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −3
Open

Fix:flaky CA E2E test "shouldn't trigger additional scale-ups" #9465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions cluster-autoscaler/e2e/cluster_size_autoscaling.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,14 +194,20 @@ var _ = SIGDescribe("Cluster size autoscaling", framework.WithSlow(), framework.
})

f.It("shouldn't trigger additional scale-ups during processing scale-up", feature.ClusterSizeAutoscalingScaleUp, func(ctx context.Context) {
e2eskipper.Skipf("Test is flaky and disabled for now")
// Wait for the situation to stabilize - CA should be running and have up-to-date node readiness info.
status, err := waitForScaleUpStatus(ctx, c, func(s *scaleUpStatus) bool {
return s.ready == s.target && s.ready <= nodeCount
}, scaleUpTriggerTimeout)
framework.ExpectNoError(err)

unmanagedNodes := nodeCount - status.ready
allNodes, err := c.CoreV1().Nodes().List(ctx, metav1.ListOptions{})
framework.ExpectNoError(err)
taintFilteredCount := 0
for _, n := range allNodes.Items {
if !isNodeTainted(&n) {
taintFilteredCount++
}
}
unmanagedNodes := taintFilteredCount - status.ready

ginkgo.By("Schedule more pods than can fit and wait for cluster to scale-up")
ReserveMemory(ctx, f, "memory-reservation", 100, nodeCount*memAllocatableMb, false, 1*time.Second)
Expand Down