Oci fix virtual node skip release 1.32

[shreyshj]

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR backports a fix for OCI clusters with mixed node types (managed nodes + virtual nodes).

Today, Cluster Autoscaler looks for the oci.oraclecloud.com/node-pool-id annotation on all non-self-managed nodes to determine the node pool a node belongs to. This breaks for virtual nodes, because virtual nodes do not have this annotation.

This change fixes that behavior by skipping virtual nodes during node pool identification, allowing Cluster Autoscaler to work correctly on mixed node clusters.

We need this in the release branch so updated images can be included in the April release, instead of shipping only the security-patched images without this fix.

Which issue(s) this PR fixes:

Fixes #NONE

Special notes for your reviewer:

This is a backport of an already merged fix for the OCI cloudprovider.

Customer impact:

• OCI Media Services is currently blocked from using Cluster Autoscaler on mixed node clusters because virtual nodes do not carry the oci.oraclecloud.com/node-pool-id annotation.

Does this PR introduce a user-facing change?

OCI Cluster Autoscaler now skips virtual nodes when resolving node pool IDs in mixed managed-node and virtual-node clusters, fixing autoscaler support for this configuration.

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

Welcome @shreyshj!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @shreyshj. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shreyshj
Once this PR has been reviewed and has the lgtm label, please assign towca for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

• ✅ login: abdelrahman882 / name: Omran (785772b, c77c82a)
• ✅ login: atwamahmoud / name: Mahmoud Atwa (712dddd)
• ✅ login: BigDarkClown / name: Bartłomiej Wróblewski (2454edf)
• ✅ login: Bryce-Soghigian / name: Bryce Soghigian (6a11385)
• ✅ login: ceuity / name: ceuity (06e8b8d)
• ✅ login: Choraden / name: Hubert Grochowski (d369dd7)
• ✅ login: comtalyst / name: Robin D. (fbe4465, fe5d0b0, 5b14f11)
• ✅ login: comtalyst / name: Robin Deeboonchai (381b1eb, 3d4efd3, 5ae76d7)
• ✅ login: damikag / name: Damika Gamlath (35910b4)
• ✅ login: DaThumpingRabbit / name: Sebastien Bene (4181275)
• ✅ login: gvnc / name: Güvenç Kazancı (9852206)
• ✅ login: HadrienPatte / name: Hadrien Patte (893a33c)
• ✅ login: idebeijer / name: idb (b0e5227)
• ✅ login: idebeijer / name: idebeijer (57d8f63)
• ✅ login: jackfrancis / name: Jack Francis (75eb791, 0b816e5, 0ecc396, 1b41a40, 1c51052, 1c759ba, 2d8258c, 45c8dbf, 4819923, 488f0bf, 49e52fb, 52400dc, 56332d8, 6d9e966, 962b09c, b690a99, b6f4588, ca92a57, cdd7a4e, d72f49a, e86bbf5, ef83059, f39b8bc, f558161, f5e40d5, f9112e1)
• ✅ login: jinglinliang / name: jinglinliang (5e08238, 966f57f)
• ✅ login: jlamillan / name: jesse.millan (304172e)
• ✅ login: k8s-ci-robot / name: Kubernetes Prow Robot (02eb05a, 08f5fa2, 0c1ffe1, 1226d78, 17f9131, 19dfc81, 246ca50, 2b71261, 2cbd4fd, 3d72369, 4a65d6e, 51eab96, 52147e1, 58a0c03, 5c3b385, 68fefc9, 6d51d9a, 7070f90, 7142fe3, 71f9f45, 7417da3, 78f4f4f, 790fc62, 79b9292, 7bee7ba, 8aac337, 946bbcb, 960c4d1, 986a943, 98891b9, 9952269, a13eb69, a221e41, a44fc91, aa7e3dd, ad37af9, adadd3d, b596926, bc1af03, c6c2cae, c93c528, cb1147f, cf536da, d282052, d480d46, d554f27, e389ba8, f302c91, f482d33, f645beb, fbcf0f1)
• ✅ login: louisportay / name: Louis PORTAY (f8fb361)
• ✅ login: lukasmetzner / name: lukasmetzner (cc62dc1)
• ✅ login: lxuan94-pp / name: Xuan Liu (c286de8)
• ✅ login: MaximilianoUribe / name: Maximiliano Uribe (a82efa7)
• ✅ login: MaximilianoUribe / name: Maximiliano Uribe Falcon (4face02, 6a11385, afeb62d, bc85ed2)
• ✅ login: MaximilianoUribe / name: muribefalcon (e0c8459)
• ✅ login: maximrub / name: Maxim Rubchinsky (13b656a, 8d634ba, f0d3b51)
• ✅ login: MenD32 / name: MenD32 (0013562, 3ecc695, c57c11a)
• ✅ login: mtrqq / name: Maksym Fuhol (2e7c6a8, 968be63)
• ✅ login: mu-soliman / name: Muhammad Soliman (add8851, d537d02)
• ✅ login: nojnhuh / name: Jon Huhn (0b3ae4a)
• ✅ login: norbertcyran / name: Norbert Cyran (75bf64f, feeb1f7)
• ✅ login: punkwalker / name: Pankaj Walke (4265ac4, b19d611)
• ✅ login: rrangith / name: Rahul Rangith (73dacb7)
• ✅ login: vbhargav875 / name: Vijay Bhargav Eshappa (6e331cc, 15fd6f6)
• ✅ login: wenxuan0923 / name: Thalia Wang (923f112, 9ed76e5)
• ✅ login: wjunott / name: Jun Wang (75eb791)
• ✅ login: x13n / name: Daniel Kłobuszewski (1330f57, 6613443, b0e5227, bb78e6a)
• ✅ login: yanjar / name: Jared Yanna (7e0e6d3)
• ❌ - login: @k8s-infra-cherrypick-robot / name: k8s-infra-cherrypick-robot . The commit (75eb791, bc85ed2, fbe4465, fe5d0b0) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.