Skip to content

[Perf] Optimize findMigWithMatchingBasename with O(1) prefix map lookup#9476

Draft
tetianakh wants to merge 1 commit intokubernetes:masterfrom
tetianakh:basename
Draft

[Perf] Optimize findMigWithMatchingBasename with O(1) prefix map lookup#9476
tetianakh wants to merge 1 commit intokubernetes:masterfrom
tetianakh:basename

Conversation

@tetianakh
Copy link
Copy Markdown
Contributor

@tetianakh tetianakh commented Apr 10, 2026

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implements O(1) prefix map lookup in findMigWithMatchingBasename to avoid O(N) linear search over all MIGs when resolving MIG for an instance.

Whn GetMigforInstance is called for deleted nodes, the deleted nodes are never in the cache, so findMigWithMatchingBasename is always executed. On a large cluster that has a lot of deleted nodes, each GetMigforInstance call site (which iterates over all nodes) can take a few seconds.

Benchmark results (scale: 200 MIGs, 200 ready nodes, 100 deleted nodes, 100 upcoming nodes):

Metric Before (Unoptimized) After (Optimized) Difference
Time 5.099 ms ± 27% 3.230 ms ± 40% -36.64%
Memory 1164.6 KiB ± 1% 563.9 KiB ± 1% -51.58%
Allocs 3.398k ± 2% 8.246k ± 0% +142.69%

The optimization reduces CPU time by ~36% and memory allocations by ~50% at this scale.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Implement O(1) prefix map lookup in findMigWithMatchingBasename to avoid O(N) linear search over all MIGs when resolving MIG for an instance.

Benchmark results (scale: 200 MIGs, 200 ready nodes, 100 deleted nodes, 100 upcoming nodes):

| Metric | Before (Unoptimized) | After (Optimized) | Difference |
| :--- | :--- | :--- | :--- |
| Time | 5.099 ms ± 27% | 3.230 ms ± 40% | -36.64% |
| Memory | 1164.6 KiB ± 1% | 563.9 KiB ± 1% | -51.58% |
| Allocs | 3.398k ± 2% | 8.246k ± 0% | +142.69% |

The optimization reduces CPU time by ~36% and memory allocations by ~50% at this scale.

Includes benchmark test file and README.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Apr 10, 2026
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/provider/gce labels Apr 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @tetianakh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tetianakh
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-area labels Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cluster-autoscaler area/provider/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants